Skip to content

api/notif: Rename FcmMessageStreamRecipient to FcmMessageChannelRecipient #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

Khader-1
Copy link
Collaborator

Fixes parts of #631

@Khader-1 Khader-1 added the buddy review GSoC buddy review needed. label Jul 26, 2024
@Khader-1 Khader-1 requested a review from rajveermalviya July 26, 2024 16:18
Copy link
Member

@rajveermalviya rajveermalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, moving on to mentor review from @kenclary

@rajveermalviya rajveermalviya requested a review from kenclary July 27, 2024 06:38
@rajveermalviya rajveermalviya added mentor review GSoC mentor review needed. integration review Added by maintainers when PR may be ready for integration and removed buddy review GSoC buddy review needed. mentor review GSoC mentor review needed. labels Jul 27, 2024
@rajveermalviya rajveermalviya requested a review from gnprice July 27, 2024 09:42
@gnprice gnprice force-pushed the rename-fcm-message-stream-recipient branch from 916dc3e to 6b99a72 Compare July 28, 2024 01:42
@gnprice
Copy link
Member

gnprice commented Jul 28, 2024

Thanks! Looks good — merging.

@gnprice gnprice merged commit 6b99a72 into zulip:main Jul 28, 2024
1 check passed
@Khader-1 Khader-1 deleted the rename-fcm-message-stream-recipient branch July 28, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants