Skip to content

api: Rename stream to channel in events #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

Khader-1
Copy link
Collaborator

Fixes parts of #631

@Khader-1 Khader-1 added the buddy review GSoC buddy review needed. label Jul 26, 2024
@Khader-1 Khader-1 requested a review from rajveermalviya July 26, 2024 19:41
Copy link
Member

@rajveermalviya rajveermalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, moving on to mentor review from @kenclary

@rajveermalviya rajveermalviya requested a review from kenclary July 27, 2024 06:40
@rajveermalviya rajveermalviya added mentor review GSoC mentor review needed. and removed buddy review GSoC buddy review needed. labels Jul 27, 2024
@Khader-1
Copy link
Collaborator Author

Khader-1 commented Jul 27, 2024

Thanks @rajveermalviya for the review! I'm going to skip mentor review and maintainer review for this one.
Refer to Greg's comment on #801

let's use an abbreviated process where we go straight from buddy review to integration review, skipping mentor review and maintainer review.

@Khader-1 Khader-1 added integration review Added by maintainers when PR may be ready for integration and removed mentor review GSoC mentor review needed. labels Jul 27, 2024
@Khader-1 Khader-1 requested a review from gnprice July 27, 2024 08:04
@gnprice
Copy link
Member

gnprice commented Jul 28, 2024

Thanks! These changes look good — merging.

I squashed the four commits into one, because they're all closely related and the size of the diff remained quite manageable; from git log --stat:

 lib/api/model/events.dart           | 34 +++++++++++++++++-----------------
 lib/api/model/events.g.dart         | 12 ++++++------
 lib/model/channel.dart              |  6 +++---
 lib/model/store.dart                |  4 ++--
 test/model/test_store.dart          |  2 +-
 test/widgets/message_list_test.dart |  2 +-
 6 files changed, 30 insertions(+), 30 deletions(-)

@gnprice gnprice force-pushed the rename-stream-to-channel-in-events branch from 312e225 to c89af39 Compare July 28, 2024 01:45
@gnprice gnprice merged commit c89af39 into zulip:main Jul 28, 2024
1 check passed
@Khader-1 Khader-1 deleted the rename-stream-to-channel-in-events branch July 28, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants