api: Rename to ChannelDestination and ChannelPostPolicy from "stream" #846
Conversation
sm-sayedi
added
integration review
Khader-1
force-pushed
the
rename-stream-destination
branch
from
11e3319 to
0bd2a12
Compare
gnprice
changed the title
There was a problem hiding this comment.
Thanks @Khader-1! Merging the ChannelPostPolicy / StreamPostPolicy part of this.
On ChannelDestination, see below.
(The PR branch also contained #847. It's fine to stack one PR atop another one whenever that's helpful, but do be sure to mention it in the PR description because it's important context for reviewers. Since I closed #847 for reasons described there, I'm dropping those commits here too.)
lib/api/route/messages.dart
Outdated
| StreamDestination() => { | ||
| ChannelDestination() => { | ||
| 'type': RawParameter('stream'), |
There was a problem hiding this comment.
This is a similar story to #847 — StreamDestination describes part of our outgoing API where we say "stream", and so I'd like to package the rename together with starting to say "channel" in what we send. The server does accept "channel" here:
https://zulip.com/api/send-message#parameter-type
gnprice
force-pushed
the
rename-stream-destination
branch
from
0bd2a12 to
1964388
Compare
|
FTR since GitHub makes dropped commits hard to find: that StreamDestination / ChannelDestination commit was: |
Fixes parts of #631.
This focuses on two models:
ChannelDestinationChannelPostPolicy