api: Rename StreamMessage to ChannelMessage
#848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khader-1
changed the title
StreamMessage to ChannelMessage
sm-sayedi
added
integration review
Khader-1
force-pushed
the
rename-stream-message-to-channel-message
branch
from
775beb1 to
ecaf03a
Compare
gnprice
reviewed
Aug 3, 2024
| /// Construct an example stream message. | ||
| /// Construct an example stream channel. |
| StreamMessage streamMessage({ | ||
| ChannelMessage channelMessage({ |
There was a problem hiding this comment.
Because this function eg.streamMessage has a huge number of references (333 of them, says my IDE), its rename should go in its own commit, separate from editing other things that refer to StreamMessage or "stream messages".
That'd help make the changes easier to review — including self-review to catch things like "example stream channel" noted above.
|
Closing this PR as part of pushing back the priority of the remaining portion of this issue #631: details at #631 (comment). Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes parts of #631