Reset backoff duration after successful connection. #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
reviewed
Aug 8, 2024
test/api/backoff_test.dart
Outdated
Comment on lines
20
to
29
| // probability < 1e-9. There are 2 * 11 assertions, and each one has a | ||
| // failure probability < 1e-12; see below. | ||
| // probability < 1e-9 for up to 1000 assertions. | ||
| // There are 2 * [expectedMaxDurationsInMs.length] assertions, | ||
| // and each one has a failure probability < 1e-12; see below. |
There was a problem hiding this comment.
The part "for up to 1000 assertions" is new in this commit. What does it mean, and is there a logic change it corresponds to?
There was a problem hiding this comment.
This commit allows an arbitrary number of expected durations to be passed, so the 1000 is here to convey how many expected values can be passed for the upper bound of 1e-9 to still hold.
chrisbobbe
added
the
integration review
|
After having a discussion with Greg, we will drop the testing part of this because this change is easy to verify, but testing is complicated. |
Fixes: zulip#554 Signed-off-by: Zixuan James Li <[email protected]>
Adapted from the text I wrote at zulip#554.
|
Thanks @PIG208, and thanks @chrisbobbe for the previous review! Merging, with an additional commit adding a long comment: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #554, and supersedes #564.