api: Centralize interpreting HTTP response in one place #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And have FakeApiConnection set up its own fake http.Client.
Turns out that bundling these three fields together wasn't really doing anything useful for us. The API connection objects can hold the realm URL and the auth-header value separately instead.
|
Thanks, LGTM! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Stacked atop #93.)
This helps set us up for #37: we're going to add significant new logic for interpreting the HTTP response from an API call, in order to throw appropriate exceptions, and in order to do that we'll want just one place for that logic to have to go.
As a bonus, this also simplifies the code, with a net negative diffstat, and makes the core API layer more testable.