Skip to content

made List and Map items non-nullable #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

made List and Map items non-nullable #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc9a86
make List and Map items non-nullable
ArpanMondalGITHUB Sep 21, 2024
756371a
fix: made List and Map items non-nullable and update the pigeon
ArpanMondalGITHUB Oct 25, 2024
6aaf506
Merge branch 'main' into test
ArpanMondalGITHUB Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pigeon/notifications.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ class MessagingStyle {

final Person user;
final String? conversationTitle;
// TODO(pigeon): Make list item non-nullable, once pigeon supports non-nullable type arguments.
// https://github.com/flutter/flutter/issues/97848
final List<MessagingStyleMessage?> messages;
//Made list item non-nullable
final List<MessagingStyleMessage> messages;
final bool isGroupConversation;
}

Expand All @@ -129,7 +129,8 @@ class Notification {
Notification({required this.group, required this.extras});

final String group;
final Map<String?, String?> extras;
//Made Map item non-nullable
final Map<String, String> extras;
// Various other properties too; add them if needed.
}

Expand Down
4 changes: 2 additions & 2 deletions pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,10 +871,10 @@ packages:
dependency: "direct dev"
description:
name: pigeon
sha256: ba3727eabe6c23876605d05062de35ab861227ff87a77379898ecd0b8951ef49
sha256: bb5505b81fc9c718911fe7188c88a67566c37497a66f4d4abcfe29fb08614ea3
url: "https://pub.dev"
source: hosted
version: "20.0.2"
version: "22.6.0"
platform:
dependency: transitive
description:
Expand Down
3 changes: 1 addition & 2 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,7 @@ dev_dependencies:
flutter_lints: ^4.0.0
ini: ^2.1.0
json_serializable: ^6.5.4
legacy_checks: ^0.1.0
pigeon: ^20.0.1
pigeon: 22.6.0
plugin_platform_interface: ^2.1.8
stack_trace: ^1.11.1
test: ^1.23.1
Expand Down
Loading