test [nfc]: Introduce "finish" helper for async checks #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there is an issue with the dependency: |
|
Oops, thanks. I had a commit for that but it was missing from the PR branch — I think I must have accidentally dropped it when moving the changes to an independent branch, after developing them on top of #934. Should be fixed now. |
|
LGTM! Should be ready to merge then. |
This brings the file test/api/core_test.dart up to being clean against the `unawaited_futures` lint rule, toward zulip#731. It does so with a smaller diff, and simpler resulting code, than by adding `await` on each of the futures. For comparison: zulip#934 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the file test/api/core_test.dart up to being clean against the
unawaited_futureslint rule, toward #731.It does so with a smaller diff, and simpler resulting code, than by adding
awaiton each of the futures. For comparison:#934 (comment)