Skip to content

api [nfc]: Update notif-token routes based on API docs #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Oct 15, 2024

When we originally wrote the bindings for these routes, they weren't
yet documented, so we invented our own names for them. Now they are,
so the API docs give canonical names. Switch to those,
and mark the appid parameter required as the docs say.

When we originally wrote the bindings for these routes, they weren't
yet documented, so we invented our own names for them.  Now they are,
so the API docs give canonical names.  Switch to those.
This is required for current servers, since server-8.

The original binding for this route didn't mark it as required
because it was based on the reverse-engineered binding in
zulip-mobile, and that one hadn't been updated for server-8.
Now that the endpoint has API docs, we can use the information
they tell us.
@gnprice
Copy link
Member Author

gnprice commented Oct 15, 2024

Prompted by the initial commits of #948.

@gnprice
Copy link
Member Author

gnprice commented Oct 16, 2024

CI failed on 5 unit tests, all in test/model/database_test.dart and looking like this:

❌ /home/runner/work/zulip-flutter/zulip-flutter/test/model/database_test.dart: non-migration tests create account (failed)
  Invalid argument(s): Failed to load dynamic library 'libsqlite3.so': libsqlite3.so: cannot open shared object file: No such file or directory
  dart:ffi                                                        new DynamicLibrary.open
  package:sqlite3/src/ffi/load_library.dart 52:27                 _defaultOpen
  package:sqlite3/src/ffi/load_library.dart 127:12                OpenDynamicLibrary.openSqlite
  package:sqlite3/src/ffi/api.dart 13:39                          sqlite3
  package:drift/native.dart 313:12                                _NativeDelegate.openDatabase
  package:drift/src/sqlite3/database.dart 79:19                   Sqlite3Delegate.open
  package:drift/src/runtime/executor/helpers/engines.dart 431:22  DelegatedDatabase.ensureOpen.<fn>

Seems like an infra issue that's clearly unrelated to this PR.

I'll rerun the check and see if the issue is repeatable. If so, we should adjust our CI setup file to resolve it.

@chrisbobbe
Copy link
Collaborator

I'm going to click "Re-run jobs" here:

image

because it looks like it should succeed now: #999 (comment)

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Oct 16, 2024

(Looks like that worked; all checks passed this time.)

@chrisbobbe chrisbobbe merged commit b10677e into zulip:main Oct 16, 2024
1 check passed
@chrisbobbe
Copy link
Collaborator

Thanks, LGTM! Merged.

@gnprice gnprice deleted the pr-notif-api branch October 16, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants