ActionSheet [nfc]: Update signature of actionsheet to use streamId.

This is to facilitate complete migration to using stream id for
actionsheet functions instead of stream name.

Author: AkashDhiman

src/message/__tests__/messageActionSheet-test.js

@@ -62,12 +62,14 @@ describe('constructTopicActionButtons', () => {
   const streamMessage = eg.streamMessage();
   const streamName = streamNameOfStreamMessage(streamMessage);
   const topic = streamMessage.subject;
+  const streamId = streamMessage.stream_id;
 
   test('show Unmute topic option if topic is muted', () => {
     const mute = deepFreeze([[streamName, topic]]);
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, mute },
       streamName,
+      streamId,
       topic,
     });
     expect(buttonTitles(buttons)).toContain('Unmute topic');
@@ -77,6 +79,7 @@ describe('constructTopicActionButtons', () => {
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, mute: [] },
       streamName,
+      streamId,
       topic,
     });
     expect(buttonTitles(buttons)).toContain('Mute topic');
@@ -87,6 +90,7 @@ describe('constructTopicActionButtons', () => {
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, subscriptions },
       streamName,
+      streamId,
       topic,
     });
     expect(buttonTitles(buttons)).toContain('Unmute stream');
@@ -97,6 +101,7 @@ describe('constructTopicActionButtons', () => {
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, subscriptions },
       streamName,
+      streamId,
       topic,
     });
     expect(buttonTitles(buttons)).toContain('Mute stream');
@@ -107,6 +112,7 @@ describe('constructTopicActionButtons', () => {
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, ownUser },
       streamName,
+      streamId,
       topic,
     });
     expect(buttonTitles(buttons)).toContain('Delete topic');
@@ -116,6 +122,7 @@ describe('constructTopicActionButtons', () => {
     const buttons = constructTopicActionButtons({
       backgroundData: baseBackgroundData,
       streamName,
+      streamId,
       topic,
     });
     expect(buttonTitles(buttons)).not.toContain('Delete topic');

src/message/messageActionSheet.js

@@ -39,6 +39,7 @@ export type ShowActionSheetWithOptions = (
 type TopicArgs = {
   auth: Auth,
   streamName: string,
+  streamId: number,
   topic: string,
   subscriptions: Subscription[],
   dispatch: Dispatch,
@@ -230,6 +231,7 @@ cancel.errorMessage = 'Failed to hide menu';
 export const constructTopicActionButtons = ({
   backgroundData: { mute, ownUser, streams, subscriptions },
   streamName,
+  streamId,
   topic,
 }: {|
   backgroundData: $ReadOnly<{
@@ -240,6 +242,7 @@ export const constructTopicActionButtons = ({
     ...
   }>,
   streamName: string,
+  streamId: number,
   topic: string,
 |}): Button<TopicArgs>[] => {
   const buttons = [];
@@ -397,6 +400,7 @@ export const showTopicActionSheet = ({
   backgroundData,
   topic,
   streamName,
+  streamId,
 }: {|
   showActionSheetWithOptions: ShowActionSheetWithOptions,
   callbacks: {|
@@ -413,11 +417,13 @@ export const showTopicActionSheet = ({
     ...
   }>,
   streamName: string,
+  streamId: number,
   topic: string,
 |}): void => {
   const buttonList = constructTopicActionButtons({
     backgroundData,
     streamName,
+    streamId,
     topic,
   });
   showActionSheetWithOptions(
@@ -430,6 +436,7 @@ export const showTopicActionSheet = ({
       ...backgroundData,
       ...callbacks,
       streamName,
+      streamId,
       topic,
     }),
   );

src/streams/TopicItem.js

@@ -2,6 +2,7 @@
 import React, { useContext } from 'react';
 import { View } from 'react-native';
 import { useActionSheet } from '@expo/react-native-action-sheet';
+import invariant from 'invariant';
 
 import styles, { BRAND_COLOR, createStyleSheet } from '../styles';
 import { RawLabel, Touchable, UnreadCount } from '../common';
@@ -58,6 +59,9 @@ export default function TopicItem(props: Props) {
     flags: getFlags(state),
   }));
 
+  const currentStream = [...backgroundData.streams.entries()].find(x => x[1].name === streamName);
+  invariant(currentStream !== undefined, 'No stream with provided stream name was found.');
+
   return (
     <Touchable
       onPress={() => onPress(streamName, name)}
@@ -67,6 +71,7 @@ export default function TopicItem(props: Props) {
           callbacks: { dispatch, _ },
           backgroundData,
           streamName,
+          streamId: currentStream[0],
           topic: name,
         });
       }}

src/title/TitleStream.js

@@ -81,6 +81,7 @@ const TitleStream = (props: Props) => {
                 callbacks: { dispatch, _ },
                 backgroundData,
                 streamName: stream.name,
+                streamId: stream.stream_id,
                 topic: topicOfNarrow(narrow),
               });
             }

src/webview/handleOutboundEvents.js

@@ -1,6 +1,7 @@
 /* @flow strict-local */
 import { Clipboard, Alert } from 'react-native';
 
+import invariant from 'invariant';
 import * as NavigationService from '../nav/NavigationService';
 import * as api from '../api';
 import config from '../config';
@@ -214,11 +215,17 @@ const handleLongPress = (
   const { dispatch, showActionSheetWithOptions, backgroundData, narrow, startEditMessage } = props;
   if (target === 'header') {
     if (message.type === 'stream') {
+      const streamName = streamNameOfStreamMessage(message);
+      const currentStream = [...backgroundData.streams.entries()].find(
+        x => x[1].name === streamName,
+      );
+      invariant(currentStream !== undefined, 'No stream with provided stream name was found.');
       showTopicActionSheet({
         showActionSheetWithOptions,
         callbacks: { dispatch, _ },
         backgroundData,
-        streamName: streamNameOfStreamMessage(message),
+        streamName,
+        streamId: currentStream[0],
         topic: message.subject,
       });
     } else if (message.type === 'private') {