compat: Warn on unsupported or soon-unsupported server versions #5218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it available for use outside the `logging` module. Also take the opportunity to give it some test cases.
This will let us get a better idea of how many (or few) users will be affected as we drop support for an old version, or as we remove compatibility hacks for old versions we already say we don't support.
chrisbobbe
approved these changes
Feb 2, 2022
| * | ||
| * This should be the next major Zulip Server version after kMinSupportedVersion. | ||
| */ | ||
| export const kNextMinSupportedVersion: ZulipVersion = new ZulipVersion('3.0'); |
There was a problem hiding this comment.
Is the "k" for "constant"? 🤔
There was a problem hiding this comment.
Yeah. This is influenced by Google style:
https://google.github.io/styleguide/cppguide.html#Constant_Names
I don't have any desire to go sweeping through existing code, but I'm dissatisfied with SCREAMING_SNAKE_CASE because it's more of a pain to type, and also more different from the other names we use. So wanted to experiment with this style.
|
Merged. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us get a better idea of how many (or few) users
will be affected as we drop support for an old version, or as
we remove compatibility hacks for old versions we already say
we don't support.
In particular, I have a draft branch to start relying on server 2.0+, following up on #5192. One of the main things it does is clean up how we send messages, to use stream IDs and user IDs instead of emails and stream names. That'll be a much-appreciated improvement… but it will also mean we break some pretty core functionality for any users interacting with a server that's still on a pre-2.0 version.
We announced rather a while ago, the middle of last year, that we were no longer supporting such old versions. We even started showing a warning banner for any users on such a server, and haven't heard a peep from users seeing it. So we aren't going to shy away from making that change. But it might be the cue for us to start outright refusing to operate on those servers, as discussed at 401b3a2. Knowing how many users are still in this situation will help us decide whether to build that now.
This will also help us decide when it's a good time to drop support for server 2.1 and start requiring server 3.x+, and so on in the future.