Migrate from mypy_extensions to typing_extensions#769
Merged
neiljp merged 3 commits intozulip:masterfrom Aug 10, 2020
Merged
Conversation
PyPy 7.3.1 is required to work around a bug with using typing_extensions.TypedDict. https://foss.heptapod.net/pypy/pypy/-/issues/3278 PyPy 7.3.1 is only available for PyPy >=3.6.
TypedDict requires an external module until Python 3.8; typing-extensions is a newer equivalent of mypy-extensions that contains types likely to be incorporated into typing in future version of Python.
neiljp
force-pushed
the
2020-08-09-typing-extensions
branch
from
63e6dc2 to
8105f6e
Compare
kaustubh-nair
approved these changes
Aug 10, 2020
Member
kaustubh-nair
left a comment
kaustubh-nair
left a comment
There was a problem hiding this comment.
Okay, this looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires the PyPy build to be upgraded due to a failure in earlier PyPy versions.
This also upgrades the mypy we test against - this doesn't require any changes, however.