ui/boxes: Improve behaviour of non reply compose keys.#947
Closed
mkp6781 wants to merge 1 commit intozulip:mainfrom
Closed
ui/boxes: Improve behaviour of non reply compose keys.#947mkp6781 wants to merge 1 commit intozulip:mainfrom
mkp6781 wants to merge 1 commit intozulip:mainfrom
Conversation
Brings in consistent behaviour for use of non reply compose keys `x`/`c`. Now, keypresses `x` and `c` always opens up `private_box_view` and `stream_box_view` respectively. Earlier, non reply compose hotkeys were configured for use only when focus was on the `MiddleColumnView`. This commit expands its scope to enable use of `x`/`c` even when focus is on users list, stream list, topics list, or top buttons. Tests added. Fixes zulip#871
Member
|
Hello @zulip/server-hotkeys members, this pull request was labeled with the "area: hotkeys" label, so you may want to check it out! |
Member
|
Heads up @mkp6781, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Collaborator
|
@mkp6781 Thanks for fixing this 🎉 I've merged this with updates to the commit text and to include an expected result in the parametrized test, rather than conditional code, which makes the tests clearer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings in consistent behaviour for use of non reply compose keys
x/c.Now, keypresses
xandcalways opens upprivate_box_viewandstream_box_viewrespectively.Earlier, non reply compose hotkeys were configured for use only when focus
was on the
MiddleColumnView. This commit expands its scope to enable useof
x/ceven when focus is on users list, stream list, topics list, ortop buttons.
Tests added.
Fixes #871