Skip to content

Improve UI and styling for the "/poll" widget to be shippable #11010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 7 tasks
timabbott opened this issue Dec 10, 2018 · 18 comments
Closed
3 of 7 tasks

Improve UI and styling for the "/poll" widget to be shippable #11010

timabbott opened this issue Dec 10, 2018 · 18 comments

Comments

@timabbott
Copy link
Member

timabbott commented Dec 10, 2018

The Zulip webapp has an experimental /poll slash command feature, currently disabled in most Zulip organizations because it's very unpolished. We've been hearing from a lot of folks that they'd like it on Zulip Cloud, so it's worth making an initial TODO list of what needs to happen before it can be shipped. Here's my list:

  • Change the "Edit question" UI to just be an edit-pencil button rather than a large "Edit question" button.
  • Move the "Add option" text box below the results section.
  • Style the results section to look nicer; ideally, including some sort of more visual display where large numbers of votes jump out.
  • Use nicer button styles.

These might not be blockers but would also be really high value.

  • Add slash command typeahead: [wip] Add typeahead for slash commands. #10267
  • Make the default UI for setting the initial question text be to include it as an argument in the slash command.
  • Probably a bunch more little styling/UI things, but we can worry about those once the strong blockers are done.

The JS code for this widget is in static/js/voting_widget.js, static/templates/widgets/poll-widget.handlebars, and various CSS files.

@zulipbot
Copy link
Member

Hello @zulip/server-integrations, @zulip/server-message-view members, this issue was labeled with the "area: integrations", "area: message view" labels, so you may want to check it out!

@showell
Copy link
Contributor

showell commented Dec 11, 2018

This is mostly CSS/HTML work. The main todos possibly require zero JS changes, although you'll probably need to understand the JS code.

@rht
Copy link
Collaborator

rht commented Dec 15, 2018

On another note, what about adding a settings group called "Experimental features"? This way, testing can be outsourced to zulipchat.com, not just on czo.

@timabbott
Copy link
Member Author

Generally we just add things in the place they should go, and tag them as "experimental". It's not super hard to do that here, but I also don't think it's any less work than just fixing the widget.

timabbott added a commit that referenced this issue Dec 16, 2018
This is the more normal ordering for a poll.  Fixes part of #11010.
@rht
Copy link
Collaborator

rht commented Dec 17, 2018

but I also don't think it's any less work than just fixing the widget.

I'm not referring just to the "/poll" widget but to all the experimental "lab" features. Isolating them in a group helps to reinforce that they are experimental.

@timabbott
Copy link
Member Author

I understand. We used to have such a settings area, and we removed it because we preferred having individual experimental features where they belong in the settings UI.

@ishanrai05
Copy link
Collaborator

@zulipbot claim

ishanrai05 added a commit to ishanrai05/zulip that referenced this issue Dec 21, 2018
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
@zulipbot
Copy link
Member

zulipbot commented Dec 27, 2018

Hello @ishanrai05, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@Varunvaruns9
Copy link
Collaborator

I would like to take this up if no one is working on it already. @zulipbot claim

@ishanrai05
Copy link
Collaborator

@Varunvaruns9 I am almost done with the edit pencil thing... so i would request you do the other parts of this issue

@Varunvaruns9
Copy link
Collaborator

I thought this was abandoned. Please continue @ishanrai05 👍

ishanrai05 added a commit to ishanrai05/zulip that referenced this issue Jan 3, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
ishanrai05 added a commit to ishanrai05/zulip that referenced this issue Jan 3, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
ishanrai05 added a commit to ishanrai05/zulip that referenced this issue Jan 4, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
ishanrai05 added a commit to ishanrai05/zulip that referenced this issue Jan 4, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
ishanrai05 added a commit to ishanrai05/zulip that referenced this issue Jan 4, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
@Varunvaruns9
Copy link
Collaborator

@ishanrai05 you can reclaim the issue if you are working on it.

@Varunvaruns9
Copy link
Collaborator

Maybe we can add a special highlight if the current user votes on a given option, something like this:

screen shot 2019-01-06 at 2 48 45 am

@timabbott
Copy link
Member Author

@Varunvaruns9 seems like a reasonable addition.

@ishanrai05
Copy link
Collaborator

@zulipbot claim

@ishanrai05
Copy link
Collaborator

@zulipbot abandon

showell pushed a commit to showell/zulip that referenced this issue Jan 15, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
showell pushed a commit to showell/zulip that referenced this issue Jan 17, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
timabbott pushed a commit that referenced this issue Jan 22, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of #11010.
@timabbott
Copy link
Member Author

Closing, since this was mostly resolved via 85535ae and related commits. We should still work on the follow-ups that have their own issue.

YashRE42 pushed a commit to YashRE42/zulip that referenced this issue Jan 24, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
TharunThomas8 pushed a commit to TharunThomas8/zulip that referenced this issue Jan 26, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
benneyman pushed a commit to benneyman/zulip that referenced this issue Jan 28, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
benneyman pushed a commit to benneyman/zulip that referenced this issue Jan 29, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
benneyman pushed a commit to benneyman/zulip that referenced this issue Feb 4, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
benneyman pushed a commit to benneyman/zulip that referenced this issue Feb 4, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
benneyman pushed a commit to benneyman/zulip that referenced this issue Feb 7, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
benneyman pushed a commit to benneyman/zulip that referenced this issue Feb 7, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
benneyman pushed a commit to benneyman/zulip that referenced this issue Feb 7, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
vrongmeal pushed a commit to vrongmeal/zulip that referenced this issue Feb 13, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
ruchit2801 pushed a commit to ruchit2801/zulip that referenced this issue Feb 13, 2019
This is the more normal ordering for a poll.  Fixes part of zulip#11010.
ruchit2801 pushed a commit to ruchit2801/zulip that referenced this issue Feb 13, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
Nikhil-Vats pushed a commit to Nikhil-Vats/zulip that referenced this issue Mar 17, 2019
This changes the "Edit question" UI to be just an edit-pencil button
rather than a large "Edit question" button for a poll.
Fixes part of zulip#11010.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants