-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Improve UI and styling for the "/poll" widget to be shippable #11010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @zulip/server-integrations, @zulip/server-message-view members, this issue was labeled with the "area: integrations", "area: message view" labels, so you may want to check it out! |
This is mostly CSS/HTML work. The main todos possibly require zero JS changes, although you'll probably need to understand the JS code. |
On another note, what about adding a settings group called "Experimental features"? This way, testing can be outsourced to zulipchat.com, not just on czo. |
Generally we just add things in the place they should go, and tag them as "experimental". It's not super hard to do that here, but I also don't think it's any less work than just fixing the widget. |
This is the more normal ordering for a poll. Fixes part of #11010.
I'm not referring just to the "/poll" widget but to all the experimental "lab" features. Isolating them in a group helps to reinforce that they are experimental. |
I understand. We used to have such a settings area, and we removed it because we preferred having individual experimental features where they belong in the settings UI. |
@zulipbot claim |
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
Hello @ishanrai05, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
I would like to take this up if no one is working on it already. @zulipbot claim |
@Varunvaruns9 I am almost done with the edit pencil thing... so i would request you do the other parts of this issue |
I thought this was abandoned. Please continue @ishanrai05 👍 |
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
@ishanrai05 you can reclaim the issue if you are working on it. |
@Varunvaruns9 seems like a reasonable addition. |
@zulipbot claim |
@zulipbot abandon |
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of #11010.
Closing, since this was mostly resolved via 85535ae and related commits. We should still work on the follow-ups that have their own issue. |
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This is the more normal ordering for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
This changes the "Edit question" UI to be just an edit-pencil button rather than a large "Edit question" button for a poll. Fixes part of zulip#11010.
Uh oh!
There was an error while loading. Please reload this page.
The Zulip webapp has an experimental
/poll
slash command feature, currently disabled in most Zulip organizations because it's very unpolished. We've been hearing from a lot of folks that they'd like it on Zulip Cloud, so it's worth making an initial TODO list of what needs to happen before it can be shipped. Here's my list:These might not be blockers but would also be really high value.
The JS code for this widget is in
static/js/voting_widget.js
,static/templates/widgets/poll-widget.handlebars
, and various CSS files.The text was updated successfully, but these errors were encountered: