Add support for parsing raw hex values via \x
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaluka
reviewed
Oct 10, 2023
JoeKar
commented
Oct 11, 2023
dmaluka
reviewed
Oct 11, 2023
JoeKar
changed the title
\x
dmaluka
reviewed
Oct 12, 2023
dmaluka
reviewed
Oct 12, 2023
dmaluka
reviewed
Oct 14, 2023
dmaluka
approved these changes
Oct 15, 2023
Author
|
The commit with the functional change (https://github.com/JoeKar/json5/commit/b3d35fc725d60e2ea4ae7eacc875966828f20efb) is now cherry-picked into https://github.com/micro-editor/json5/tree/micro as micro-editor@9569b62 and tagged to v1.0.1-micro. Now only the dependency must be changed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to handle
\xnotated hex values parsed the same easy way as it currently allows/parses\unotated unicode characters.zyedidia/micro#2950