-
Notifications
You must be signed in to change notification settings - Fork 1.3k
release: Use GitHub Actions for manually triggered builds and artifact uploads #3397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you point at where it is? Also almost off-topic: what's going on with https://github.com/zyedidia/micro/releases/tag/nightly ? Why are there are not just the up-to-date |
Only via the nightly as example, since the workflow will be available first in the moment it's merged to the master. But it will then look like this:
Hm, from my point of view it was obvious that we can't solve this without the help of @zyedidia, since he needs to stop his (cron?) triggered nightly build. See also #3334 (comment) & starting from #3334 (comment) downwards. |
|
Thanks. Regarding @zyedidia's cron job - yeah indeed, somehow I missed that discussion or forgot about it, and I hadn't noticed this weirdness myself until yesterday. |
|
Probably LGTM. I'm assuming you've tested this in your fork? |
|
Yes, I run it there with a custom tag I created. |
|
The first test with
Because the auto generated change history seems to sum it up the best by listing all PRs automatically. Right now we've to edit the created release and have to click on a button. What do you think? |
|
I.e. Ok, let's enable it. I think this automatic description is not good enough, it just dumps everything without emphasizing/summarizing major changes interesting to users, but let's have it by default and edit it as we see fit. Or maybe no need to enable it, since we already have this generated for BTW before |
No, I clicked on that option while modifying the release name etc.
Depends on the perspective. Seems like a matter of preferences what should be the default. At least the title needs to be manually modified anyway, since this doesn't fit to the current "scheme". |
It would barely make any difference to me. :) |

The release will by default include the description (title and body) of the
tagused as input (in case of a manual trigger).This will add one more option to create the release, besides the fully manually approach where the artifacts must be build locally and uploaded afterwards. We can then just start the action with the
tagbyUse workflow fromand the GitHub sandbox will create all artifacts and attach it to the release. No local resources are needed.Fixes #3322