Fix regression in CopyLine, CutLine, DeleteLine for last line #3519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression introduced in commit fdacb28 ("CopyLine, CutLine, DeleteLine: respect selection"): when CopyLine, CutLine or DeleteLine is done in the last line of the buffer and this line is not empty, this line gets selected but does not get copied/cut/deleted (and worse, it remains selected).
JoeKar
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in commit fdacb28 ("CopyLine, CutLine, DeleteLine: respect selection"): when
CopyLine,CutLineorDeleteLineis done in the last line of the buffer and this line is not empty, this line gets selected but does not get copied/cut/deleted (and worse, it remains selected).Reported by @niten94 in #3335 (comment)