run onBeforeTextEvent also for undo and redo events
#3589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Andriamanitra this could be relevant to Micro LSP if it is merged. |
matthias314
force-pushed
the
m3/onbeforetextevent
branch
from
98f33b7 to
236d177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onBeforeTextEventis not documented, but it has been discussed here, for example. Currently this callback is only called for "new" events, but not for those coming from undo or redo events. This means that these latter events are missed if one usesonBeforeTextEventto monitor how a buffer changes. This PR fixes this by moving the invocation of the callback to a function that is also called for undo and redo events.