fix cycling through completion suggestions ending in non-word character

[Andriamanitra]

The fix is only relevant for certain plugins, but I think this is more correct behavior anyway.

fixes #3649

[matthias314]

I've come across the same issue for the LaTeX plugin I'm working on, and I've come up with the same fix matthias314@f13dc1c. It works well.

[Andriamanitra]

I've come across the same issue for the LaTeX plugin I'm working on, and I've come up with the same fix matthias314@f13dc1c. It works well.

Good to know that this patch is not entirely useless to everyone besides me, and that's funny that you came up with the exact same fix! 😄 My first thought was to separate Autocomplete and CycleAutocomplete and change the default binding for Tab to CycleAutocomplete|Autocomplete|Indent|InsertTab. I still think that would be slightly more elegant solution – but it would mess with users' keybindings so I decided against it.

[matthias314]

I think it's better to modify Autocomplete because this problem already arises when starting autocompletion. For example, for my LaTeX plugin, when I press TAB after \ref{, I want to start autocompletion with all labels defined in the file. If one only changed CycleAutocomplete, then that wouldn't work because of the { character.

[JoeKar]

Can we have more than one suggestion (b.HasSuggestions = true), when the cursor is at the first position in the line?

micro/internal/buffer/autocomplete.go

Line 72 in b88300e

if c.X == 0 || util.IsWhitespace(b.RuneAt(c.Loc.Move(-1, b))) {

Says no, or?
Is it possible in plugins?

Otherwise maybe merge this check with h.Cursor.HasSelection() into:

	if h.Cursor.HasSelection() || h.Cursor.X == 0 {
		return false
	}

[matthias314]

Is it possible in plugins?

Who knows? Giving plugin developers more freedom is better In my opinion than saving a few lines of code.

[Andriamanitra]

I don't know of a use case for suggestions at the start of the line but I tend to agree with @matthias314 – rather keep the option available just in case.

[JoeKar]

Hm...the question was more targeted into the direction if there was a special reason to move the black above if h.Cursor.X == 0 { and not below?

I don't know of a use case for suggestions at the start of the line [...]

So it was an unconscious decision? 😉

Anyway, if you both think it might be relevant in the future...then fine by me.