Pr 3032 fw/v3#3044
Open
victorjulien wants to merge 10 commits intoOISF:masterfrom
Open
Conversation
This was referenced Apr 23, 2026
Closed
victorjulien
force-pushed
the
pr-3032-fw/v3
branch
from
d23aee1 to
510eae7
Compare
This was referenced May 1, 2026
Add suricata-verify tests for keywords that emit 'has not been tes for firewall rules' warnings. Tests are consolidated into 3 test cases. - firewall-keyword-icode: tests icode with ICMP echo traffic - firewall-keyword-http: tests pcre, urilen, dataset with HTTP traff - firewall-keyword-tls: tests tls.cert_chain_len with TLS cert chain These tests validate that the keywords function correctly in firewal mode and can be used to justify adding SIGMATCH_SUPPORT_FIREWALL to each keyword in the engine. Related to Ticket #8387
Based on initial work by Yash Datre - dns.opcode - dns.query with datarep Related to Ticket #8387
Related to Ticket #8387
Ticket: #8495.
victorjulien
force-pushed
the
pr-3032-fw/v3
branch
from
510eae7 to
4de17cf
Compare
This test shows how an accept flow on an http request will skip thread detection on http response data.
victorjulien
force-pushed
the
pr-3032-fw/v3
branch
from
4de17cf to
f43e62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3039 rebased, renumbered and with more tests added.