chore(react18): Migrate legacy react methods

[justinpark]

SUMMARY

This commit migrates legacy lifecycle methods to their newer versions as part of the upgrade process to React 18.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI and specs

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Redundant Object.keys() Computation ▹ view	🧠 Not in scope

Files scanned

​

File Path	Reviewed
superset-frontend/src/components/Datasource/types.ts	✅
superset-frontend/src/dashboard/components/menu/WithPopoverMenu.tsx	✅
superset-frontend/src/explore/components/controls/SelectControl.jsx	✅
superset-frontend/src/dashboard/components/Dashboard.jsx	✅
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx	✅
superset-frontend/src/components/Datasource/CollectionTable.tsx	✅
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/index.jsx	✅
superset-frontend/.eslintrc.js	✅
superset-frontend/src/dashboard/components/SliceAdder.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[michael-s-molina]

Potential Improvements

A. getDerivedStateFromProps Usage

getDerivedStateFromProps must return either a new state object or null. The code mostly does this; however, there are cases where it always returns an object, even if nothing changed (e.g., { prevCollection: nextProps.collection }).
Best Practice: Only return the minimal state update if something actually changed.
Impact: This can cause unnecessary re-renders but is technically correct. It’s a minor efficiency concern.

B. State Naming

Adding keys like prevCollection, prevLastUpdated, etc., to state is a common workaround. However, this can make the state object larger and more complex.
Best Practice: If the component only needs to react to changes (not keep a historical value), consider comparing props directly in componentDidUpdate.
Impact: Not a bug, but can increase cognitive load for maintainers.

C. Possible Missed Edge Cases

In some components (e.g., AdhocFilterControl), derived state is always returned, even when not necessary. This may cause extra renders.
In WithPopoverMenu, the derived state always returns { needsClickListner: undefined } if neither condition matches, which may also cause extra renders.

[justinpark]

Potential Improvements

A. getDerivedStateFromProps Usage

getDerivedStateFromProps must return either a new state object or null. The code mostly does this; however, there are cases where it always returns an object, even if nothing changed (e.g., { prevCollection: nextProps.collection }). Best Practice: Only return the minimal state update if something actually changed. Impact: This can cause unnecessary re-renders but is technically correct. It’s a minor efficiency concern.

B. State Naming

Adding keys like prevCollection, prevLastUpdated, etc., to state is a common workaround. However, this can make the state object larger and more complex. Best Practice: If the component only needs to react to changes (not keep a historical value), consider comparing props directly in componentDidUpdate. Impact: Not a bug, but can increase cognitive load for maintainers.

C. Possible Missed Edge Cases

In some components (e.g., AdhocFilterControl), derived state is always returned, even when not necessary. This may cause extra renders. In WithPopoverMenu, the derived state always returns { needsClickListner: undefined } if neither condition matches, which may also cause extra renders.

Sounds good. Minimized the getDerievedStateFromProps and use componentDidUpdate instead.