Skip to content

Fix FastDDS test dependencies not guarded by --ros2 flag on Linux and Windows#9669

Merged
Blyron merged 1 commit intoue4-devfrom
luis/issue_9668
Apr 14, 2026
Merged

Fix FastDDS test dependencies not guarded by --ros2 flag on Linux and Windows#9669
Blyron merged 1 commit intoue4-devfrom
luis/issue_9668

Conversation

@LuisPovedaCano
Copy link
Copy Markdown
Contributor

@LuisPovedaCano LuisPovedaCano commented Apr 13, 2026

Fixes #9668

Server tests no longer pull in FastDDS headers or link fastrtps/fastcdr/foonathan when --ros2 is not passed. test_dds_middleware.cpp is also excluded from the source glob in that case.

Setup.sh and Setup.bat now both emit LIBCARLA_WITH_ROS2 into the generated CMakeLists.txt.in so the flag is set on both platforms.

Setup.bat: pin foonathan_memory_vendor to v1.3.2 (matches Setup.sh) so Windows builds the same library version as Linux and Carla.Build.cs expect.

CMakeLists.txt: replace hardcoded foonathan version in lib filenames with a glob so future version bumps do not require manual edits. Adds a FATAL_ERROR if the library is not found.

Where has this been tested?

  • Tested in Ubuntu
  • Tested in Windows

This change is Reviewable

@LuisPovedaCano LuisPovedaCano self-assigned this Apr 13, 2026
@update-docs
Copy link
Copy Markdown

update-docs Bot commented Apr 13, 2026

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

@LuisPovedaCano LuisPovedaCano marked this pull request as ready for review April 13, 2026 22:05
@LuisPovedaCano LuisPovedaCano requested a review from a team as a code owner April 13, 2026 22:05
@Blyron Blyron merged commit c94e932 into ue4-dev Apr 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants