Fix FastDDS test dependencies not guarded by --ros2 flag on Linux and Windows#9669
Merged
Fix FastDDS test dependencies not guarded by --ros2 flag on Linux and Windows#9669
Conversation
on Linux and Windows
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
Blyron
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9668
Server tests no longer pull in FastDDS headers or link
fastrtps/fastcdr/foonathanwhen--ros2is not passed.test_dds_middleware.cppis also excluded from the source glob in that case.Setup.shandSetup.batnow both emitLIBCARLA_WITH_ROS2into the generatedCMakeLists.txt.inso the flag is set on both platforms.Setup.bat: pinfoonathan_memory_vendortov1.3.2(matches Setup.sh) so Windows builds the same library version as Linux andCarla.Build.csexpect.CMakeLists.txt: replace hardcoded foonathan version in lib filenames with a glob so future version bumps do not require manual edits. Adds aFATAL_ERRORif the library is not found.Where has this been tested?
This change is