feat(RecordCommunitiesService): Add get_record_requests service method#2294
Open
sakshamarora1 wants to merge 1 commit intoinveniosoftware:masterfrom
Open
feat(RecordCommunitiesService): Add get_record_requests service method#2294sakshamarora1 wants to merge 1 commit intoinveniosoftware:masterfrom
sakshamarora1 wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
* Moved from invenio_app_rdm/records_ui/views/records.py * Since the function checks for permissions and also access the API layer, it should be a service method following the existing methods in this service class also accessing the communities API
Comment on lines
+512
to
+546
| parent = record._record.parent | ||
| community_requests = parent.communities.get_requests() | ||
| community_requests = { | ||
| str(request.community_id): str(request.request_id) | ||
| for request in community_requests | ||
| } | ||
|
|
||
| # Get the requests that concern only the current record, i.e. submission or inclusion regardless of their status | ||
| # This takes precedence over only considering accepted requests because there may be an unaccepted request in this | ||
| # version of the record that should be shown instead of the accepted request. | ||
| record_requests = current_requests_service.search( | ||
| identity, | ||
| extra_filter=dsl.Q( | ||
| "bool", | ||
| must=[ | ||
| dsl.Q("term", **{"topic.record": record.id}), | ||
| dsl.Q( | ||
| "terms", | ||
| **{ | ||
| "type": [ | ||
| CommunityInclusion.type_id, | ||
| CommunitySubmission.type_id, | ||
| ] | ||
| }, | ||
| ), | ||
| ], | ||
| ), | ||
| params={"sort": "oldest"}, | ||
| ) | ||
| record_requests = { | ||
| request["receiver"]["community"]: request["id"] | ||
| for request in record_requests | ||
| } | ||
|
|
||
| community_requests.update(record_requests) |
Contributor
There was a problem hiding this comment.
Doesn't this potentially overwrite requests? If a community have an accepted request from parent.communities.get_requests() and a pending request?
Contributor
Author
There was a problem hiding this comment.
Then the pending request is shown. Only in case there is no request for the record as a topic, it will show the accepted request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: inveniosoftware/invenio-requests#568
requires: inveniosoftware/invenio-communities#1361