add new offset attribute to browser-action-list to determine the popup offset #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilian
changed the title
|
Manually including an offset isn't necessary in this case. The underlying issue was that the popup didn't consider the native titlebar height (0f1fded). |
|
That is incorrect. The calculation you do here results in a nativeTitlebarHeight of 0 because getBounds and getContentBounds are identical on linux. Did you verify it isn't also 0 for you? A manual offset value is still needed to fix this issue and is also more broadly useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux systems don't correctly calculate the offset of elements in the page when the WM draws the browserWindow Chrome. This causes getBoundingClientRect to return values that are incorrect when used outside of the browserWindow. This adds an optional
offsetattribute to browser-action-list to tweak the offset of the popup to take this into account.Fixes #121
✅ By sending this pull request, I agree to the Contributor License Agreement of this project.