fix (electron-chrome-extensions): always disconnect native port when native messaging host is destroyed #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdless of native messaging host connection status
aavshr
changed the title
onDisconnect event when native messaging host is destroyed
samuelmaddock
approved these changes
Jul 1, 2025
| } | ||
|
|
||
| destroy() { | ||
| if (!this.connected) return |
There was a problem hiding this comment.
If destroy() is called twice, this will still attempt to send an IPC to this.sender. I'll fix this up after merging.
| } | ||
| ipcRenderer.on(`crx-native-msg-${connectionId}`, onMessage) | ||
| ipcRenderer.once(`crx-native-msg-${connectNative}-disconnect`, () => { | ||
| ipcRenderer.once(`crx-native-msg-${connectionId}-disconnect`, () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently the
connectedguard is stillfalsewhendestroyis called even if the extension native messaging config/host could not be found. The native port is never closed on these errors and hence also theonDisconnectevent is never emitted for potential listeners. This PR gets rid of theconnectedguard check and also fixes a typo on the disconnect ipc channel name.✅ By sending this pull request, I agree to the Contributor License Agreement of this project.