Skip to content

fix (electron-chrome-extensions): always disconnect native port when native messaging host is destroyed #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

fix (electron-chrome-extensions): always disconnect native port when native messaging host is destroyed #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
688c1c4
fix (electron-chrome-extensions): fix typo on native msg disconnect i…
aavshr Jun 26, 2025
0e17b30
fix (electron-chrome-extensions): send native disconnect message rega…
aavshr Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/electron-chrome-extensions/src/browser/api/lib/native-messaging-host.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ export class NativeMessagingHost {
}

destroy() {
if (!this.connected) return
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If destroy() is called twice, this will still attempt to send an IPC to this.sender. I'll fix this up after merging.

this.connected = false
if (this.process) {
this.process.kill()
Expand Down
2 changes: 1 addition & 1 deletion packages/electron-chrome-extensions/src/renderer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export const injectExtensionAPIs = () => {
receive(message)
}
ipcRenderer.on(`crx-native-msg-${connectionId}`, onMessage)
ipcRenderer.once(`crx-native-msg-${connectNative}-disconnect`, () => {
ipcRenderer.once(`crx-native-msg-${connectionId}-disconnect`, () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, good catch!

ipcRenderer.off(`crx-native-msg-${connectionId}`, onMessage)
disconnect()
})
Expand Down