Skip to content

qt-3d: add new package for Qt3D (Qt6)#4883

Open
melven wants to merge 4 commits into
spack:developfrom
melven:qt-3d-add-package
Open

qt-3d: add new package for Qt3D (Qt6)#4883
melven wants to merge 4 commits into
spack:developfrom
melven:qt-3d-add-package

Conversation

@melven
Copy link
Copy Markdown
Contributor

@melven melven commented May 17, 2026

Adds a package for the Qt3d in Qt6.

@melven
Copy link
Copy Markdown
Contributor Author

melven commented May 17, 2026

Requires #4882 because I only tested the newest version.

@melven melven marked this pull request as draft May 17, 2026 15:54

license("LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only", checked_by="melven")

version("6.11.1", commit="1f4c3a7548201bcad21a273a49060c96ad9ff3a9", submodules=True)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to use the commit + submodules even when you use the external assimp? The disadvantage of using the commit-based versioning is that spack checksum qt3d won't pick up any new versions for adding.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry.

It does not pick up the external assimp, so I removed the assimp dependency instead.
I tried some workarounds by setting CMake flags / qt features but didn't get it to work...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wdconinc

this would be ready for merging from my side, so we can continue with the PySide6 PR.

@melven
Copy link
Copy Markdown
Contributor Author

melven commented May 18, 2026

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented May 18, 2026

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented May 18, 2026

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/qt_3d/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted
�[1;34m==> �[0mrunning ruff check
All checks passed!
�[1;34m==> �[0mstyle checks passed
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@melven melven marked this pull request as ready for review May 18, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants