Fix #92: Tell user when filter categories are reset

[jmstacey]

Fix for #92 -
Tell the user when we're changing something that they've selected. The trigger in this case is when the selected number of rules is greater than what Safari allows.

Clarify that the rule count in stats refers to the number of applied Safari rules which will likely differ from the source count as a result of the rule conversions to Safari.

[gemini-code-assist]

Summary of Changes

Hello @jmstacey, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #92 by enhancing user feedback when filter categories are automatically reset due to exceeding Safari's content blocker rule limits. It also improves the clarity of the displayed rule count in the application's statistics, ensuring it accurately reflects the number of rules successfully applied by Safari rather than just the source count.

Highlights

• Enhanced User Notification: Implemented a new mechanism to explicitly inform users via a warning alert when selected filter categories are automatically reset because they exceed Safari's rule capacity. This replaces a less prominent status description update.
• Accurate Rule Count Aggregation: Refined the calculation of overallSafariRulesApplied to ensure that only rules from categories that were successfully processed (i.e., not reset due to limits) contribute to the total, providing a more accurate representation.
• Corrected Filter List Iteration: Updated the logic for processing reset rules to ensure it iterates over the currently selected filters after a reset has occurred, preventing potential issues with stale data.
• Improved UI Clarity for Rule Stats: Renamed the "Filter Rules" display in the application's statistics to "Applied Rules" to clearly indicate that this count represents the rules successfully applied by Safari, which may differ from the initial source rule count.
• Robust Rule Count Display Logic: Adjusted the displayedRuleCount property to prioritize showing the lastRuleCount from the filter manager if available and greater than zero, otherwise falling back to the sourceRulesCount, making the displayed value more reliable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves user feedback by notifying them when filter categories are reset due to rule limits. It also clarifies the rule count statistic to refer to applied Safari rules. The changes are logical and well-implemented. I've provided a few suggestions to improve code clarity and remove redundant logic.