Support canvas.toDataURL("image/jpeg") (sync) #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a bug I introduced in Automattic#1152 (JPEG quality needs to go from 0 to 1, not 0 to 100). Fixes Automattic#1146
LinusU
reviewed
Jul 3, 2018
| @@ -663,38 +663,31 @@ describe('Canvas', function () { | |||
| ctx.fillRect(100,0,100,100); | |||
|
|
|||
| it('toDataURL() works and defaults to PNG', function () { | |||
| assert.ok(0 == canvas.toDataURL().indexOf('data:image/png;base64,')); | |||
| assert.ok(canvas.toDataURL().startsWith('data:image/png;base64,')); | |||
chearon
approved these changes
Jul 5, 2018
|
@zbjornson This is very cool! |
|
It's heavily 2.x, but once the memory leaks are addressed I think 2.x can be released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing, standard sync API; we only had async.
Also fixes a bug I introduced in #1152 (JPEG quality needs to go from 0 to 1, not 0 to 100).
Fixes #1146
Also allows some code to be freed up in JSDOM (jsdom/jsdom#2199).