toDataURL callback for jpeg #4667
Conversation
nodejs: provide callback from fabric.toDataURL to canvas.toDataURL when format is jpeg
|
JPEG todataurl is async on nodecanvas? |
|
Yup, it is async. In canvas there is a jpeg stream where the callback with the base64 data triggers when the stream ends. |
|
how jsdom solves this? any idea? |
|
No idea, sorry. |
|
The same code diff needs to apply to 1.x branch. I'm just updating my fork. |
|
Hi, I'm running into this issue as well. What's the status of this PR? Are there any known workarounds for this? It looks like node-canvas recently merged a fix: Automattic/node-canvas#1194. |
|
So if we could backport the nodecanvas fix in the 1.x branch that would be awesome, otherway we need to update to nodecanvas 2, and fork jsdom 9.x in order to support nodecanvas 2 or fork jsdom latest in order to support nodecanvas 2 and also drop support for node 4 and so bump fabric version to 3.0 |
|
this has been fixed with nodecanvas 2 |
Problem: in nodejs there was no way to get jpeg data back from canvas as fabric did not provide a way to pass through a callback.
Solution: just added in a callback argument in the functions from fabric.toDataURL to canvas.toDataURL