Skip to content

Use Nan::TypedArrayContents, fix a signed/unsigned comp warning #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2015

Conversation

zbjornson
Copy link
Collaborator

Fixes #637, plus a compiler warning. Was also able to remove some unnecessary code that creates an ArrayBuffer explicitly in CanvasRenderingContext2d.

@zbjornson
Copy link
Collaborator Author

(5.0 fails as expected)

@LinusU
Copy link
Collaborator

LinusU commented Nov 21, 2015

Tested Node 5.x manually and it works for me, pulling.

Very nice, thanks for the help 💯 👍

LinusU added a commit that referenced this pull request Nov 21, 2015
Use Nan::TypedArrayContents, fix a signed/unsigned comp warning
@LinusU LinusU merged commit 83d9da9 into Automattic:master Nov 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants