Use Nan::TypedArrayContents, fix a signed/unsigned comp warning #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(5.0 fails as expected) |
|
Tested Node 5.x manually and it works for me, pulling. Very nice, thanks for the help 💯 👍 |
LinusU
added a commit
that referenced
this pull request
Nov 21, 2015
Use Nan::TypedArrayContents, fix a signed/unsigned comp warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #637, plus a compiler warning. Was also able to remove some unnecessary code that creates an ArrayBuffer explicitly in CanvasRenderingContext2d.