Skip to content

Can we use Nan::TypedArrayContents #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LinusU opened this issue Oct 8, 2015 · 4 comments
Closed

Can we use Nan::TypedArrayContents #637

LinusU opened this issue Oct 8, 2015 · 4 comments

Comments

@LinusU
Copy link
Collaborator

LinusU commented Oct 8, 2015

@zbjornson I think that this can help some of your ifdefs, it will be released with Nan 2.1

nodejs/nan#486
@zbjornson
Copy link
Collaborator

Looks like it will help with at least some cases. Creating new typed arrays might still need directives. Will play with it when it's in release.

@LinusU
Copy link
Collaborator Author

LinusU commented Oct 9, 2015

It's already in release ;)

@zbjornson zbjornson mentioned this issue Oct 12, 2015
Merged
@zbjornson zbjornson mentioned this issue Oct 22, 2015
Merged
@LinusU
Copy link
Collaborator Author

LinusU commented Oct 23, 2015

Tried it out myself, it's super easy to use :)

encode.cc
LinusU/node-lodepng@f5b68e1

zbjornson added a commit to zbjornson/node-canvas that referenced this issue Nov 19, 2015
@zbjornson
Automattic#637 use Nan::TypedArrayContents, fix a signed/unsigned com…
83a8b27 
…p warning
@zbjornson zbjornson mentioned this issue Nov 19, 2015
Merged
@zbjornson
Copy link
Collaborator

See also nodejs/nan#521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LinusU @zbjornson