Add helper method for accessing typedarray contents (squashed) #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move typedarray contents to v8 misc helper docs fix style errors, use const and more descriptive types more style tweaks style tweaks, assert on alignment and missing typedarrays remove alignof, do not assert fail on versions < 0.8 add better alignment checks for msc, g++ and c++11 fix up signature use __cplusplus for checking if alignof available, unify msc and gnuc fallbacks, defer assigning to data_ until after assertion add failing test case for node 0.12 access buffer property from arraybufferview before reading in order to force v8 to externalize it change docs to force CI to rerun remove unneeded type qualifiers which trigger spurious warnings on gcc
|
Merged as 17b5129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a new PR for this, since the previous one was a bit cluttered and I also had a fork of NAN which used that branch, and pushing the rebased code would've broken it. This PR is rebased, squashed and merges cleanly into the master.