-
Notifications
You must be signed in to change notification settings - Fork 64
Add trigger binding support #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
591638f to
565df26
Compare
4c9c2ed to
bb95d88
Compare
b335234 to
5050b5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add both unit and integration tests covering the functionality of this feature.
(also make sure you merge in latest from main and fix any build errors. We had to go back to netstandard2.0 from netstandard2.1 for bundle support which means some language features aren't available)
d25d7c0 to
2a721b4
Compare
25871ac to
24aac02
Compare
|
reminder: this PR needs to be retargeted to a feature branch for trigger support and not merged to main edit: this is already in a feature branch |
5c0cff4 to
6e33204
Compare
Charles-Gagnon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a few comments to take a look at but overall looks good enough to me.
Although I want there to be a lot more debug logging done in all the parts. I'm not seeing any in SqlTableChangeMonitor for example. In general here are the things I'll be looking for :
- Message at the start of every task and sub task (
Getting changes from table,Updating state tables,Getting list of changes,Got changed rows {....}) and so on. The goal should be to be able to tell exactly where something went wrong and what it was doing when an issue occurs, regardless of where that was. - Log queries executed and how long they took
- Extra logging around any of the locking (include thread IDs if that isn't included by default)
- Make sure all errors are logged with any extra information that may be helpful in determining cause of the error
@lucyzhang929 @MaddyDev Please help make sure that we get as complete of a logging story as we can - we want to have as much as we can now before we give this to customers.
Also we should make sure to get basic usage telemetry set up - we can get some amount of stuff from the AF folks but that won't include people running locally so it'd be good to make sure we have a complete story ourselves as well. I'll follow up separately on my thoughts for that to get started.
Created #287 for this one. |
|
Closing this pull request as it need not be merged soon and need not be reviewed further. When the |
No description provided.