Skip to content

Add new integration tests for trigger binding #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JatinSanghvi merged 7 commits into from
Aug 25, 2022
Merged

Add new integration tests for trigger binding #296

JatinSanghvi merged 7 commits into from
Aug 25, 2022

Conversation

@JatinSanghvi
Copy link
Contributor

@JatinSanghvi JatinSanghvi commented Aug 18, 2022 •
edited
Loading

  1. Closes Improve error handling when user table has primary column with conflicting names #309
  2. Add integration test to verify the behavior for various error conditions.

@JatinSanghvi JatinSanghvi mentioned this pull request Aug 18, 2022
Closed
@JatinSanghvi JatinSanghvi changed the title Jatin sanghvi/trigger integration tests Add more integration tests Aug 18, 2022
@JatinSanghvi JatinSanghvi mentioned this pull request Aug 18, 2022
Closed
@JatinSanghvi JatinSanghvi changed the title Add more integration tests Add new integration tests for trigger binding Aug 18, 2022
JatinSanghvi
JatinSanghvi commented Aug 18, 2022
View reviewed changes
@JatinSanghvi JatinSanghvi mentioned this pull request Aug 18, 2022
Closed
@JatinSanghvi JatinSanghvi force-pushed the JatinSanghvi/trigger-integration-tests branch from 9cb8c34 to 503144d Compare August 18, 2022 09:12
@JatinSanghvi JatinSanghvi mentioned this pull request Aug 18, 2022
Merged
Charles-Gagnon
Charles-Gagnon requested changes Aug 18, 2022
View reviewed changes
Charles-Gagnon
Charles-Gagnon reviewed Aug 18, 2022
View reviewed changes
@JatinSanghvi JatinSanghvi force-pushed the JatinSanghvi/trigger-integration-tests branch from 8ffe78b to 0d71bbd Compare August 23, 2022 08:53
@Charles-Gagnon
Copy link
Contributor

Charles-Gagnon commented Aug 23, 2022

There are some tests failing - please fix those before merging in.

@JatinSanghvi JatinSanghvi linked an issue Aug 24, 2022 that may be closed by this pull request
Improve error handling when user table has primary column with conflicting names #309
Closed
@JatinSanghvi JatinSanghvi merged commit f1b2739 into triggerbindings Aug 25, 2022
@JatinSanghvi JatinSanghvi deleted the JatinSanghvi/trigger-integration-tests branch August 25, 2022 00:58
@JatinSanghvi JatinSanghvi mentioned this pull request Sep 13, 2022
Merged
PBBlox pushed a commit to PBBlox/azure-functions-sql-extension that referenced this pull request Apr 6, 2025
@JatinSanghvi
Add new integration tests for trigger binding (Azure#296)
f7b186b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@chlafreniere chlafreniere Awaiting requested review from chlafreniere

@MaddyDev MaddyDev Awaiting requested review from MaddyDev

+1 more reviewer

@lucyzhang929 lucyzhang929 lucyzhang929 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve error handling when user table has primary column with conflicting names

4 participants

@JatinSanghvi @Charles-Gagnon @lucyzhang929