Sync eng/common directory with azure-sdk-tools for PR 10616 #24633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
requested review from
Copilot and
hallipr
and removed request for
hallipr
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with the latest changes from azure-sdk-tools (PR 10616) to ensure consistency in link verification scripts.
- Updated regex match variable naming and verbose logging
- Introduced HTML decoding of URLs before resolution
Comments suppressed due to low confidence (1)
eng/common/scripts/Verify-Links.ps1:266
- [nitpick] Consider renaming the variable '$matches' to a more descriptive name such as '$hrefMatches' to clarify its purpose.
$matches = [RegEx]::Matches($htmlContent, $hrefRegex, $regexOptions);
hallipr
approved these changes
May 14, 2025
azure-sdk
deleted the
sync-eng/common-users/pahallis/parse-html-hrefs-10616
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10616 See eng/common workflow