HtmlDecode hrefs in Verify-Links.ps1 #10616
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
The following pipelines have been queued for testing: |
hallipr
force-pushed
the
users/pahallis/parse-html-hrefs
branch
from
ef28a3e to
b82b377
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR decodes HTML-encoded URLs in anchor hrefs to ensure that link resolution works correctly by using [System.Web.HttpUtility]::HtmlDecode.
- Renames the variable holding regex matches from $hrefs to $matches
- Adds a step to HTML-decode the href values before resolving them
- Updates verbose logging to reflect the changes
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10616 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Patrick Hallisey <[email protected]>
fixes #10601
In html, attribute values are encoded and should be decoded before use. If not decoded using
[HttpUtility]::HtmlDecode(), the url is incorrect and the server should not be expected to process it correctly.In powershell, the markdown
is converted to the html
which is regex parsed to
and needs to be HtmlDecoded to