Skip to content

Sync eng/common directory with azure-sdk-tools for PR 10616 #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10616 See eng/common workflow

@Copilot Copilot AI review requested due to automatic review settings May 14, 2025 16:31
@azure-sdk azure-sdk requested a review from a team as a code owner May 14, 2025 16:32
@azure-sdk azure-sdk requested a review from hallipr May 14, 2025 16:32
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels May 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes the eng/common directory with the latest version from azure-sdk-tools, ensuring the link verification script aligns with upstream changes.

  • Renamed the variable from $hrefs to $matches for better clarity.
  • Added decoding of HTML encoded URLs before resolving URIs.
  • Updated verbose logging to reflect the new changes.

@hallipr hallipr merged commit 2c88a42 into main May 14, 2025
25 of 28 checks passed
@hallipr hallipr deleted the sync-eng/common-users/pahallis/parse-html-hrefs-10616 branch May 14, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants