Skip to content

[Monitor OpenTelemetry Exporter] Update Statsbeat to Count Success Upon Partially Successful Envelopes #33741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JacksonWeber
Copy link
Member

Packages impacted by this PR

@azure/monitor-opentelemetry-exporter

Issues associated with this PR

Describe the problem that is addressed by this PR

Should adhere to the spec by counting a statsbeat success when some of the envelopes in a batch are accepted by breeze.

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@Copilot Copilot AI review requested due to automatic review settings April 8, 2025 20:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

sdk/monitor/monitor-opentelemetry-exporter/src/platform/nodejs/baseSender.ts:107

  • The condition checks itemsReceived > 0 which may count success even in cases where some envelopes failed. Consider refining the logic to differentiate between completely successful responses and partially successful ones if the spec requires counting each accepted envelope individually.
if (breezeResponse.itemsReceived > 0) {

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@JacksonWeber JacksonWeber merged commit 5471724 into Azure:main Apr 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants