Skip to content

[Monitor OpenTelemetry Exporter] Update Statsbeat to Count Success Upon Partially Successful Envelopes #33741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

[Monitor OpenTelemetry Exporter] Update Statsbeat to Count Success Upon Partially Successful Envelopes #33741

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3862d6
Update the base sender to include a success count upon partial accept…
JacksonWeber Apr 8, 2025
a8ed5ae
Update CHANGELOG.md
JacksonWeber Apr 8, 2025
1a6ad12
Merge branch 'main' into jacksonweber/update-response-to-spec
JacksonWeber Apr 15, 2025
f92e682
Update CHANGELOG.md for statsbeat success count
JacksonWeber Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/monitor/monitor-opentelemetry-exporter/src/platform/nodejs/baseSender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,11 @@ export abstract class BaseSender {
diag.info(result);
const breezeResponse = JSON.parse(result) as BreezeResponse;
const filteredEnvelopes: Envelope[] = [];
// If we have a partial success, count the succeeded envelopes
if (breezeResponse.itemsReceived > 0) {
this.networkStatsbeatMetrics?.countSuccess(duration);
}
// Figure out if we need to either retry or count failures
if (breezeResponse.errors) {
breezeResponse.errors.forEach((error) => {
if (error.statusCode && isRetriable(error.statusCode)) {
Expand Down
Loading