Adding in feature to generate SAS from Storage Clients #15972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnguye
requested review from
amishra-dev,
kasobol-msft,
seanmcc-msft and
tg-msft
as code owners
gapra-msft
reviewed
Oct 14, 2020
gapra-msft
reviewed
Oct 14, 2020
gapra-msft
reviewed
Oct 14, 2020
gapra-msft
reviewed
Oct 14, 2020
tg-msft
reviewed
Oct 16, 2020
Member
tg-msft
left a comment
tg-msft
left a comment
There was a problem hiding this comment.
This looks awesome! Can you do me a favor and run \eng\scripts\Export-API.ps1 to make reviewing the API surface changes easier?
tg-msft
reviewed
Oct 19, 2020
…rs, updated tests and recordings, ran export-APIs
Member
Author
|
@gapra-msft @tg-msft @kasobol-msft @seanmcc-msft could you all take another look? thanks! |
kasobol-msft
approved these changes
Oct 26, 2020
gapra-msft
reviewed
Oct 27, 2020
gapra-msft
reviewed
Oct 27, 2020
gapra-msft
reviewed
Oct 27, 2020
tg-msft
approved these changes
Oct 28, 2020
sdk/storage/Azure.Storage.Blobs/api/Azure.Storage.Blobs.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Queues/api/Azure.Storage.Queues.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
gapra-msft
approved these changes
Oct 30, 2020
|
@amnguye Hi! Just a quick question - when is this PR scheduled to be released? Is it for v (I didn't see if this was tagged to a specific issue or milestone, for reference). cheers! |
Member
Author
|
Hi @PureKrome! We are planning to release this next week for v12.5.0 ( |
|
@amnguye That's great news! thanks so much and keep up the great work 👍🏻 🍰 |
|
|
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
- All Storage Clients (except Service Clients) now have the property CanGenerateSas and the method GenerateSas - Storage Service Clients have the property CanGenerateAccountSas and the method GenerateAccountSas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each client in the Azure.Storage.* libraries, this PR adds a the following new APIs
public Uri GenerateSasUri(<service>SasBuilder builder)and for each
<service>ServiceClientthere is the also APIs forpublic Uri GenerateAccountSasUri(AccountSasBuilder builder)I also resolved #15403 in this PR as it was breaking some of my tests.
I also removed the ability/deprecated to set the sas version in blobs, as we moved to a new StringToSign.