Skip to content

QueueUriBuilder handles docker hostnames. #16543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PureKrome wants to merge 1 commit into from
Closed

QueueUriBuilder handles docker hostnames. #16543

PureKrome wants to merge 1 commit into from

Conversation

@PureKrome
Copy link

@PureKrome PureKrome commented Nov 3, 2020

Fixes #16542

@ghost ghost added Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Nov 3, 2020
@ghost
Copy link

ghost commented Nov 3, 2020

Thank you for your contribution PureKrome! We will review the pull request and get back to you soon.

@ghost
Copy link

ghost commented Nov 3, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@jsquire jsquire added Client This issue is related to a non-management package Community Contribution Community members are working on the issue Service Attention Workflow: This issue is responsible by Azure service team. and removed customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Nov 3, 2020
@jsquire
Copy link
Member

jsquire commented Nov 3, 2020

Hi @PureKrome. Thank you for helping to improve the Azure SDK experience and for your contribution. I've added some tags to help route this to the team members best able to provide feedback.

@jsquire jsquire mentioned this pull request Nov 3, 2020
Closed
@amnguye
Copy link
Member

amnguye commented Nov 3, 2020

Hi! We appreciate your contribution!

I actually was already going ahead and resolving this issue by not only adding it in Queues but also in SMB Files.
#15972

Is it okay if I close your PR in preference to the PR I just linked since we are going to look to merge this PR soon? Thanks!

@PureKrome
Copy link
Author

PureKrome commented Nov 4, 2020

Ah yes - you've done the same code. NP, i'll close this. sorry to have wasted your time.

@PureKrome PureKrome closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@amnguye amnguye Awaiting requested review from amnguye

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft

@tg-msft tg-msft Awaiting requested review from tg-msft

Assignees

No one assigned

Labels

Client This issue is related to a non-management package Community Contribution Community members are working on the issue Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] QueueUriBuilder ignores AccountName in ConnectionString if local Docker host name is used

3 participants

@PureKrome @jsquire @amnguye