add HttpError, StreamError & CosmosError #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctaggart
commented
May 17, 2021
ctaggart
changed the title
ctaggart
commented
May 17, 2021
MindFlavor
reviewed
May 18, 2021
Contributor
There was a problem hiding this comment.
I like this, great work!
Unfortunately the E2E tests are failing.
The repro is: cargo run --example create_delete_database dbname:
Error: GenericErrorWithText("String has an unrecognized part. Part: \"interopUsers=2000\", Full string: \"databases=1000;collections=5000;users=500000;permissions=2000000;interopUsers=2000;authPolicyElements=200000;\"")Edit: it does not work on master either. I have created a separate issue (#256) so I would go ahead and merge this and tackle the bug in a separate PR.
MindFlavor
approved these changes
May 18, 2021
Contributor
Author
|
@MindFlavor, thanks for the steps to reproduce. I added support for |
ctaggart
commented
May 18, 2021
| #[error("Failed to serialize request body as json: {}", 0)] | ||
| BodySerializationError(serde_json::Error), | ||
| #[error( | ||
| "Unexpected HTTP result (expected: {:?}, received: {:?}, body: {:?})", |
Contributor
Author
There was a problem hiding this comment.
This fixes #212. I added body to the error message.
| UnexpectedStatusCode { | ||
| expected: Vec<StatusCode>, | ||
| received: StatusCode, | ||
| body: String, |
Contributor
Author
There was a problem hiding this comment.
In the services, I leave this as Bytes.
This was referenced May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.