azure_core::Error & identity::Error #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
May 28, 2021
Contributor
rylev
left a comment
rylev
left a comment
There was a problem hiding this comment.
Looks good to me. I obviously didn't look at every single file, but I believe I looked at all non-generated code.
| .map(|s| -> Result<LoginResponse, Error> { | ||
| Ok(serde_json::from_str::<LoginResponse>(&s)?) | ||
| })? | ||
| // TODO The HTTP status code should be checked to deserialize an error response. |
Contributor
There was a problem hiding this comment.
Can we create an issue for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues a refactor of error handling that started in #251. The biggest changes are:
azure_core::errors::AzureErrorrenamed toazure_core::Erroridentity::Error?is usable by consumers.trait azure_core::TokenCredentialremains the sametrait azure_identity::token_credentials::TokenCredentialis the same asazure_core::TokenCredential, but returns a specific error from the azure_identity crate