Call TVP.CreateClaimsIdentity to support users that have overloaded. #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We should remove these lines as well to not change type: |
Contributor
Author
|
@keegan-caruso I haven't analyzed that, it is good that you called it out. |
Contributor
Author
|
@keegan-caruso those methods are only used by tests, i changed the tests and removed the methods. |
pmaytak
approved these changes
Jul 16, 2024
keegan-caruso
approved these changes
Jul 16, 2024
pmaytak
pushed a commit
that referenced
this pull request
Jul 16, 2024
…2716) * Call TVP.CreateClaimsIdentity to support users that have overloaded. * picked up SAML changes and TokenValidationResult * updated JwtSecurityTokenHandler, reverted tests and removed method. * touched up tests --------- Co-authored-by: id4s <[email protected]>
keegan-caruso
pushed a commit
that referenced
this pull request
Jul 16, 2024
…2716) * Call TVP.CreateClaimsIdentity to support users that have overloaded. * picked up SAML changes and TokenValidationResult * updated JwtSecurityTokenHandler, reverted tests and removed method. * touched up tests --------- Co-authored-by: id4s <[email protected]>
jennyf19
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Add CaseSensitiveClaimsIdentity type. (#2700) * Add CaseSensitiveClaimsIdentity. Update JsonWebTokenHandler. * Move switch to a separate class. Update claims identity creation code. * Add test. * Update AppContextSwitches * Update test/Microsoft.IdentityModel.Tokens.Tests/CaseSensitiveClaimsIdentityTests.cs Co-authored-by: msbw2 <[email protected]> * Update comments. * Update ClaimsIdentity code creation in src. * Add tests. * Update tests to use correct types. * Add SecurityToken property to CsClaimsIdentity. * Update tests to use CsClaimsIdentity. * Refactor code into ClaimsIdentityFactory. * Update tests. * Update ClaimsIdentityFactory. * Fix tests. * Update tests for CaseSensitiveClaimsIdentity * ignore SecurityToken in IdentityComparer * Set security token in ClaimsIdentityFactory. Add tests. * Apply suggestions from code review * Update test. --------- Co-authored-by: msbw2 <[email protected]> Co-authored-by: Keegan Caruso <[email protected]> * Make case sensitive claims identity an opt-in * Revert using CaseSensitiveClaimsIdentity by default in tests * Fix test name * Update src/Microsoft.IdentityModel.Tokens/AppContextSwitches.cs Co-authored-by: Peter <[email protected]> * Update src/Microsoft.IdentityModel.Tokens/AppContextSwitches.cs Co-authored-by: Peter <[email protected]> * Call TVP.CreateClaimsIdentity to support users that have overloaded. (#2716) * Call TVP.CreateClaimsIdentity to support users that have overloaded. * picked up SAML changes and TokenValidationResult * updated JwtSecurityTokenHandler, reverted tests and removed method. * touched up tests --------- Co-authored-by: id4s <[email protected]> * fix reference * Update src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.cs Co-authored-by: Peter <[email protected]> --------- Co-authored-by: Peter <[email protected]> Co-authored-by: msbw2 <[email protected]> Co-authored-by: Keegan Caruso <[email protected]> Co-authored-by: BrentSchmaltz <[email protected]> Co-authored-by: id4s <[email protected]>
jennyf19
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Add CaseSensitiveClaimsIdentity type. (#2700) * Add CaseSensitiveClaimsIdentity. Update JsonWebTokenHandler. * Move switch to a separate class. Update claims identity creation code. * Add test. * Update AppContextSwitches * Update test/Microsoft.IdentityModel.Tokens.Tests/CaseSensitiveClaimsIdentityTests.cs Co-authored-by: msbw2 <[email protected]> * Update comments. * Update ClaimsIdentity code creation in src. * Add tests. * Update tests to use correct types. * Add SecurityToken property to CsClaimsIdentity. * Update tests to use CsClaimsIdentity. * Refactor code into ClaimsIdentityFactory. * Update tests. * Update ClaimsIdentityFactory. * Fix tests. * Update tests for CaseSensitiveClaimsIdentity * ignore SecurityToken in IdentityComparer * Set security token in ClaimsIdentityFactory. Add tests. * Apply suggestions from code review * Update test. --------- Co-authored-by: msbw2 <[email protected]> Co-authored-by: Keegan Caruso <[email protected]> * Update. * Update. * Update. * Update. * Call TVP.CreateClaimsIdentity to support users that have overloaded. (#2716) * Call TVP.CreateClaimsIdentity to support users that have overloaded. * picked up SAML changes and TokenValidationResult * updated JwtSecurityTokenHandler, reverted tests and removed method. * touched up tests --------- Co-authored-by: id4s <[email protected]> * Update src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.cs --------- Co-authored-by: msbw2 <[email protected]> Co-authored-by: Keegan Caruso <[email protected]> Co-authored-by: BrentSchmaltz <[email protected]> Co-authored-by: id4s <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call TVP.CreateClaimsIdentity to maintain back compat for users that have overloaded TVP.CreateClaimsIdentity.