Skip to content

Move base plots from LadybugTools_Toolkit #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Nov 12, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #141

Moved all base plots that don't reference any pollination-based packages to Python_Toolkit, as well as helper and utility methods.

Also updated the .gitignore to align better with LBT_TK

Test files

Use the unit tests in Python_Toolkit and LadybugTools_Toolkit, as there should be no change to method signatures or functionality in LBT (see the PR in LadybugTools_Toolkit)

Changelog

  • Moved the following base plots from LadybugTools_Toolkit:
    • diurnal
    • stacked_diurnals
    • heatmap
    • histogram
    • monthly_proportional_histogram
    • spatial_heatmap
    • timeseries
  • Moved the following plot utility methods:
    • average_color
    • animation
    • create_title
    • contrasting_colour
    • relative_luminance
    • colormap_sequential
    • annotate_imshow
    • lighten_color
    • base64_to_image
    • image_to_base64
    • figure_to_base64
    • figure_to_image
    • tile_images
    • triangulation_area
    • create_triangulation
    • format_polar_plot
  • Moved the following helper methods:
    • validate_timeseries
    • timeseries_summary_monthly
    • cardinality
    • angle_from_cardinal
    • angle_from_north
    • angle_to_vector
    • DecayMethod (enum for decay rate methods)
    • proximity_decay
    • decay_rate_smoother
    • sanitise_string
    • convert_keys_to_snake_case
    • remove_leap_days
    • timedelta_tostring
    • safe_filename

Additional comments

@Tom-Kingstone Tom-Kingstone added status:WIP PR in progress and still in draft, not ready for formal review type:feature New capability or enhancement labels Nov 12, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Nov 12, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

@Tom-Kingstone Tom-Kingstone marked this pull request as ready for review November 13, 2024 09:52
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer
  • check versioning

There are 16 requests in the queue ahead of you.

@Tom-Kingstone Tom-Kingstone removed the status:WIP PR in progress and still in draft, not ready for formal review label Nov 13, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

There are 29 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

wrong PR 🤦

Copy link

bhombot-ci bot commented Nov 13, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 10 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

There are 43 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on LadybugTools_Toolkit

Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests working on my machine, and no loss of functionality elsewhere (though there wouldn't be, if the elsewhere code isn't referencing it yet 😄).

There are lots of changes I'd love to make to how this toolkit is handling pots, but as with most things, functionality over finesse is where we're at.

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with unit tests plus some self spot checks. No critical issues preventing merge. Any non-critical issues should have issues raised separately.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 3, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 8 requests in the queue ahead of you.

@jamesramsden-bh jamesramsden-bh merged commit 891b039 into develop Dec 3, 2024
12 checks passed
@jamesramsden-bh jamesramsden-bh deleted the Python_Toolkit-#141-BasePlots branch December 3, 2024 16:00
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create general plot methods
3 participants