-
Notifications
You must be signed in to change notification settings - Fork 2
Move base plots from LadybugTools_Toolkit #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… an init file so they can be accessed together)
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 16 requests in the queue ahead of you. |
@BHoMBot check installer |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 29 requests in the queue ahead of you. |
wrong PR 🤦 |
The check |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 43 requests in the queue ahead of you. |
@Tom-Kingstone just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests working on my machine, and no loss of functionality elsewhere (though there wouldn't be, if the elsewhere code isn't referencing it yet 😄).
There are lots of changes I'd love to make to how this toolkit is handling pots, but as with most things, functionality over finesse is where we're at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with unit tests plus some self spot checks. No critical issues preventing merge. Any non-critical issues should have issues raised separately.
@BHoMBot check ready-to-merge |
@jamesramsden-bh to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
NOTE: Depends on
Issues addressed by this PR
Closes #141
Moved all base plots that don't reference any pollination-based packages to Python_Toolkit, as well as helper and utility methods.
Also updated the .gitignore to align better with LBT_TK
Test files
Use the unit tests in Python_Toolkit and LadybugTools_Toolkit, as there should be no change to method signatures or functionality in LBT (see the PR in LadybugTools_Toolkit)
Changelog
Additional comments