Skip to content

8.0 Deployment #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Dec 19, 2024
Merged

8.0 Deployment #152

merged 38 commits into from
Dec 19, 2024

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Dec 9, 2024 •
edited by Tom-Kingstone
Loading

Python_Toolkit

Feature

  • Add python code to nuspec as content files
  • Move base plots from LadybugTools_Toolkit
    • Moved the following base plots from LadybugTools_Toolkit:
      • diurnal
      • stacked_diurnals
      • heatmap
      • histogram
      • monthly_proportional_histogram
      • spatial_heatmap
      • timeseries
    • Moved the following plot utility methods:
      • average_color
      • animation
      • create_title
      • contrasting_colour
      • relative_luminance
      • colormap_sequential
      • annotate_imshow
      • lighten_color
      • base64_to_image
      • image_to_base64
      • figure_to_base64
      • figure_to_image
      • tile_images
      • triangulation_area
      • create_triangulation
      • format_polar_plot
    • Moved the following helper methods:
      • validate_timeseries
      • timeseries_summary_monthly
      • cardinality
      • angle_from_cardinal
      • angle_from_north
      • angle_to_vector
      • DecayMethod (enum for decay rate methods)
      • proximity_decay
      • decay_rate_smoother
      • sanitise_string
      • convert_keys_to_snake_case
      • remove_leap_days
      • timedelta_tostring
      • safe_filename
  • Refactor to use the windows installer when creating a base environment
    • Updated base environment install method to use the windows installer rather than the embeddable package

Compliance

BHoMBot and others added 30 commits September 20, 2024 13:25
@BHoMBot
Update assembly file version to 8.0.0.0 and AssemblyVersion to 8.0.0.0
4b06bbb
@adecler
Start of milestone changes for 8.0 (#144)
21c3ce8
@Tom-Kingstone
initial solution for the refactor. python installer now used instead …
7fa170b 
…of embedded packages, and removed most versions from the python version enum. Utilise the installer to remove the environment, and allowed multiplt versions of python to be installed in the python toolkit folder
@Tom-Kingstone
rename the python versions to be just the major numbers to avoid conf…
2d61d79 
…usion
@Tom-Kingstone
fixed remove method
bbb5621
@Tom-Kingstone
fixed base environment install location
badc7a9
@Tom-Kingstone
use DirectoryBaseEnvironment properly everywhere
15d41fe
@Tom-Kingstone
added bhom analytics logger, and added the interpreter path (sys.exec…
1131f9e 
…utable) to CustomData within the log message.
@Tom-Kingstone
changed log entry type to be the same as the one in BHoM
09247c4
@Tom-Kingstone
add method separator for Download.cs
604532a
@Tom-Kingstone
update versioning for removed/updated methods.
a674209
@Tom-Kingstone
fix versioning keys
01eb894
@Tom-Kingstone
rename versioning file
4413c31
@Tom-Kingstone
updated wrong versioning key :P
162cf42
@Tom-Kingstone
fix key for DownloadGetPip
895c4e8
@Tom-Kingstone
updated DirectoryBaseEnvironment and BasePythonEnvironment
9fc085a
@Tom-Kingstone
add local package to base environment on install
fc0513d
@Tom-Kingstone
mistake in method signature
db51afc
@Tom-Kingstone
general compliance changes
71a1a7c
@Tom-Kingstone
revert ToPython removal (versioning doesn't play nice)
f1b93e8
@Tom-Kingstone
Update Python_Engine/Compute/BasePythonEnvironment.cs
642f2f5
@Tom-Kingstone
Made the warning for creating virtual environments clearer (need the …
660a338 
…base version installed when requesting that version)
@Tom-Kingstone
Removed error if the environment didn't exist - now downloads the req…
631ad9e 
…uired base version if it doesn't exist and leaves a note to say this.
@Tom-Kingstone
add a comment and if spacing
6561cb0
@Tom-Kingstone
properly install the base environment when asked for
3ba64bb
@Tom-Kingstone
change to run installer check again
37eb521
@jamesramsden-bh
Refactor to use the windows installer when creating a base environment (
618dfb0 
#145)
@Tom-Kingstone
moved base plots and bhom_analytics to this toolkit
c236610
@Tom-Kingstone
correct path for the timeseries helper method
50695ce
@Tom-Kingstone
added python library to nuspec content files
cfa194f
@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 12, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 12, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh I have provided force checks to the checks requested.

@alelom alelom self-requested a review December 12, 2024 16:55
alelom
alelom approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved following testing procedure.

@Dmamedova Dmamedova self-requested a review December 12, 2024 17:28
Dmamedova
Dmamedova approved these changes Dec 12, 2024
View reviewed changes
Copy link

@Dmamedova Dmamedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on testing with 241212 8.0 installer following procedures in https://burohappold.sharepoint.com/:w:/s/BHoM/EaYHwoKwLeNAiVMQbhobRFUBRyQvlDEqjLi1
u7Y7S-Vgvg?e=IK7M8U

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM_Engine

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM_Engine

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoMAnalytics_Toolkit

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 16, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Revit_UI

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 16, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_Schematic_Tool

@bhombot-ci bhombot-ci bot added the type:feature New capability or enhancement label Dec 16, 2024
@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 17, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Revit_Tagging_Tool

jamesramsden-bh
jamesramsden-bh approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as per comments in test report document.

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 19, 2024

@BHoMBot just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh IsakNaslundBh merged commit 11fed04 into main Dec 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

@jamesramsden-bh jamesramsden-bh jamesramsden-bh approved these changes

@Dmamedova Dmamedova Dmamedova approved these changes

@Tom-Kingstone Tom-Kingstone Awaiting requested review from Tom-Kingstone

@tg359 tg359 Awaiting requested review from tg359

Assignees
No one assigned
Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BHoMBot @alelom @jamesramsden-bh @Dmamedova @IsakNaslundBh @adecler @Tom-Kingstone