Closes 5172 -- adds overloads to hash in numeric.py #5217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5172.
This adds overloads to the
hashfunction in numeric.py, implements typechecking inhash, removes thetype: ignorecomment, and removes the comment describing that the function was not being typechecked.It does not add overloads to the hash functions in categorical, segarray or strings, because all of those are of the form
def hash (self).IMHO, the overloads are a bit wordy, but this is what mypy requires. I did consult chatGPT, which did not recommend breaking out the elements of the Union, since that aspect doesn't affect the output type. Only the value of
fulldoes.