Skip to content

Closes 5172 -- adds overloads to hash in numeric.py #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajpotts merged 1 commit into from
Dec 23, 2025
Merged

Closes 5172 -- adds overloads to hash in numeric.py #5217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions arkouda/numpy/numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1859,11 +1859,29 @@ def _hash_helper(a):
return a.name


# this is # type: ignored and doesn't actually do any type checking
# the type hints are there as a reference to show which types are expected
# type validation is done within the function
HashableItems = Union[pdarray, Strings, SegArray, Categorical]
HashableList = List[HashableItems]


@overload
def hash(pda: HashableItems, full: Literal[True] = True) -> Tuple[pdarray, pdarray]: ...


@overload
def hash(pda: HashableItems, full: Literal[False]) -> pdarray: ...


@overload
def hash(pda: HashableList, full: Literal[True] = True) -> Tuple[pdarray, pdarray]: ...


@overload
def hash(pda: HashableList, full: Literal[False]) -> pdarray: ...


@typechecked
def hash(
pda: Union[ # type: ignore
pda: Union[
Union[pdarray, Strings, SegArray, Categorical],
List[Union[pdarray, Strings, SegArray, Categorical]],
],
Expand Down