Skip to content

fix(supply-chain): retire the frozen v1 floating tag - #244

Merged
williaby merged 3 commits into
mainfrom
claude/retire-v1-floating-tag-0
Jul 2, 2026
Merged

williaby merged 3 commits into
mainfrom
claude/retire-v1-floating-tag-0

Conversation

@williaby

@williaby williaby commented Jul 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Resolves the Critical finding that the v1 distribution tag is frozen at v1.1.0 (6f71aec) while main is at v7.0.1, so @v1 consumers never receive security fixes.

Root cause: the org tag-protection ruleset (ByronWilliamsCPA-tag-protection-semver) blocks update/deletion/non_fast_forward on refs/tags/v*, which made the floating-tag scheme structurally impossible; the tag froze the day the ruleset landed, but docs, renovate.json, the starter templates, and two of this repo's own callers kept using it. This PR commits fully to point-tag/SHA pinning (option b, matching CI-005 and release-tag.yml's stated policy).

Changes

  • renovate.json: drop followTag: "v1" so Renovate can advance org-workflow SHA pins to the latest immutable release tag (the rule previously froze all pin updates at the dead tag); the org matcher is now an anchored matchPackageNames regex (the deprecated unanchored matchPackagePatterns form could match lookalike repo names)
  • USAGE_EXAMPLES.md: rewrite Version Pinning around @<sha> # vX.Y.Z (recommended, Renovate-managed) and immutable @vX.Y.Z point tags; state explicitly that no floating major tag exists
  • CHANGELOG.md: correct the intro that claimed v1 "is re-pointed as changes land"; document the retirement under Unreleased
  • Sweep: all @v1 usage examples (every workflow header, docs/workflows/*.md, examples/*, migration guides, READMEs) moved to the v7.0.1 SHA-pin form
  • Live pin fixes: workflow-templates/*.yml and this repo's own scorecard.yml / security-analysis.yml were SHA-pinned to the frozen 6f71aec commit (running v1.1.0-era workflow code, including the pre-feat(python-sbom)!: cut over runtime CVE gate from Trivy to Grype (#152) #229 Trivy scanner); bumped to v7.0.1
  • Guardrail: new no-floating-v1 pre-commit hook (scripts/check-no-floating-v1.sh) blocks org-workflow references to any bare floating major tag (@v1, @v2, ...; case-insensitive org match, fail-closed on git/grep errors) and followTag reintroduction across Renovate config variants, with Bats coverage in tests/check-no-floating-v1.bats

Intentionally untouched: tests/fixtures (negative fixtures for the SHA-pin audit), tests/libs (vendored), docs/audits (historical record), third-party action examples. The guard's exclusion list carves out those paths plus tests/*.bats (the update-pinned-actions suite embeds @v1 fixture literals).

Verification

  • pre-commit run --all-files green. Note: the no-floating-v1 hook itself scans staged files (same design as the PC-011 em-dash hook), so it enforces at commit time; the all-files run does not exercise it
  • Guard behavior covered by a committed Bats suite (tests/check-no-floating-v1.bats, 16 cases: blocked bare majors for both orgs including lowercased org names, allowed point tags and SHA pins, third-party @v1 actions, every path exclusion, quoted/unquoted followTag keys vs prose mentions, fail-closed git failure); runs in CI via shell-tests.yml
  • actionlint clean on the two workflows with live pin changes
  • grep -rn '6f71aec' returns nothing; no non-historical @v1 org-workflow references remain; a full-tree dry run of the guard's pattern against all tracked files matches nothing outside its exclusion list

Follow-ups (separate from this PR)

  1. Fleet: remove the replicated followTag rule from consumer repos and the cookiecutter template. The standards-manifest part is already done: CI-057 was inverted to forbid followTag on org workflow rules (.claude repo commit ac1df86, which cites this PR); still open there: devops-deployment-agent.md line 81 still instructs CI-057 to PASS only when followTag: "v1" is present and needs the same inversion
  2. Tag deletion: org admin deletes refs/tags/v1 via a one-time ruleset bypass, after re-verifying no live @v1 callers exist (stragglers then fail loudly instead of silently running stale code). Note: update-pinned-actions.sh --pin-tags deliberately skips first-party @v1 refs, so consumer-repo stragglers will not be auto-fixed; the loud failure after deletion is the detection mechanism

Generated with Claude Code

Copilot AI review requested due to automatic review settings July 2, 2026 17:30
@coderabbitai

coderabbitai Bot commented Jul 2, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@williaby, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f38be4c5-241b-4ac0-b854-8ec13e50b5d7

📥 Commits

Reviewing files that changed from the base of the PR and between d5cf991 and 0ec5407.

📒 Files selected for processing (89)
  • .claude/CLAUDE.md
  • .github/workflows/dependency-provenance-weekly.yml
  • .github/workflows/python-ci.yml
  • .github/workflows/python-codecov.yml
  • .github/workflows/python-compatibility.yml
  • .github/workflows/python-container-security.yml
  • .github/workflows/python-dependency-provenance.yml
  • .github/workflows/python-docker.yml
  • .github/workflows/python-docs.yml
  • .github/workflows/python-fips-compatibility.yml
  • .github/workflows/python-fuzzing.yml
  • .github/workflows/python-mutation.yml
  • .github/workflows/python-performance-regression.yml
  • .github/workflows/python-pr-validation.yml
  • .github/workflows/python-precommit.yml
  • .github/workflows/python-publish-pypi.yml
  • .github/workflows/python-qlty-coverage.yml
  • .github/workflows/python-qlty-gate.yml
  • .github/workflows/python-release.yml
  • .github/workflows/python-reuse.yml
  • .github/workflows/python-sbom.yml
  • .github/workflows/python-scorecard.yml
  • .github/workflows/python-security-analysis.yml
  • .github/workflows/python-snyk-iac.yml
  • .github/workflows/python-snyk.yml
  • .github/workflows/python-sonarcloud.yml
  • .github/workflows/python-standard-stack.yml
  • .github/workflows/python-supplemental-checks.yml
  • .github/workflows/scorecard.yml
  • .github/workflows/security-analysis.yml
  • .github/workflows/snyk-weekly.yml
  • .github/workflows/supply-chain-build-verify.yml
  • .github/workflows/supply-chain-consume-verify.yml
  • .github/workflows/supply-chain-mirror-verify.yml
  • .github/workflows/supply-chain-promote-core.yml
  • .pre-commit-config.yaml
  • CHANGELOG.md
  • README.md
  • USAGE_EXAMPLES.md
  • docs/migration/image-detection-pypi-migration.md
  • docs/migration/pypi-publishing-migration.md
  • docs/workflows/NEW_WORKFLOWS_SUMMARY.md
  • docs/workflows/README.md
  • docs/workflows/python-ci.md
  • docs/workflows/python-codecov.md
  • docs/workflows/python-compatibility.md
  • docs/workflows/python-container-security.md
  • docs/workflows/python-dependency-provenance.md
  • docs/workflows/python-docker.md
  • docs/workflows/python-docs.md
  • docs/workflows/python-fips-compatibility.md
  • docs/workflows/python-fuzzing.md
  • docs/workflows/python-mutation.md
  • docs/workflows/python-performance-regression.md
  • docs/workflows/python-pr-validation.md
  • docs/workflows/python-precommit.md
  • docs/workflows/python-publish-pypi.md
  • docs/workflows/python-qlty-coverage.md
  • docs/workflows/python-qlty-gate.md
  • docs/workflows/python-release.md
  • docs/workflows/python-reuse.md
  • docs/workflows/python-sbom.md
  • docs/workflows/python-scorecard.md
  • docs/workflows/python-security-analysis.md
  • docs/workflows/python-slsa.md
  • docs/workflows/python-snyk-iac.md
  • docs/workflows/python-snyk.md
  • docs/workflows/python-sonarcloud.md
  • docs/workflows/python-standard-stack.md
  • docs/workflows/python-supplemental-checks.md
  • docs/workflows/workflow-optimizations.md
  • examples/fuzzing-custom-directory.yml
  • examples/fuzzing-migration-example.md
  • examples/fuzzing-multi-sanitizer.yml
  • examples/fuzzing-pr-manual.yml
  • examples/fuzzing-weekly.yml
  • examples/publish-pypi-caller.yml
  • renovate.json
  • scripts/check-no-floating-v1.sh
  • tests/check-no-floating-v1.bats
  • workflow-templates/README.md
  • workflow-templates/python-compatibility.yml
  • workflow-templates/python-container-security.yml
  • workflow-templates/python-fips-compatibility.yml
  • workflow-templates/python-mutation.yml
  • workflow-templates/python-pr-validation.yml
  • workflow-templates/python-reuse.yml
  • workflow-templates/python-sbom.yml
  • workflow-templates/python-scorecard.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/retire-v1-floating-tag-0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR retires the frozen @v1 floating tag scheme for this reusable workflow library, switching all documented and live references to immutable pins so consumers reliably receive security updates.

Changes:

  • Replaced org reusable-workflow references from @v1 to full SHA pins (with # vX.Y.Z comments) across templates, docs, examples, and this repo’s own workflows.
  • Updated version pinning guidance and Renovate configuration to align with immutable semver point tags and SHA pin advancement.
  • Added a pre-commit guardrail to block reintroduction of org @v1 references and followTag in renovate.json.

Reviewed changes

Copilot reviewed 87 out of 87 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
workflow-templates/README.md Updates template architecture guidance to reference SHA pinning.
workflow-templates/python-scorecard.yml Updates reusable workflow pin from old frozen SHA to v7.0.1 SHA.
workflow-templates/python-sbom.yml Updates reusable workflow pin to v7.0.1 SHA.
workflow-templates/python-reuse.yml Updates reusable workflow pin to v7.0.1 SHA.
workflow-templates/python-pr-validation.yml Updates reusable workflow pin to v7.0.1 SHA.
workflow-templates/python-mutation.yml Updates reusable workflow pin to v7.0.1 SHA.
workflow-templates/python-fips-compatibility.yml Updates reusable workflow pin to v7.0.1 SHA.
workflow-templates/python-container-security.yml Updates reusable workflow pin to v7.0.1 SHA.
workflow-templates/python-compatibility.yml Updates reusable workflow pin to v7.0.1 SHA.
USAGE_EXAMPLES.md Rewrites pinning guidance and replaces @v1 examples with v7.0.1 SHA pins.
scripts/check-no-floating-v1.sh Adds pre-commit script to detect org @v1 usage and followTag in renovate.json.
renovate.json Removes followTag: "v1" and updates Renovate rule description for SHA advancement.
README.md Updates primary usage examples from @v1 to a v7.0.1 SHA pin.
examples/publish-pypi-caller.yml Updates example caller to v7.0.1 SHA pin.
examples/fuzzing-weekly.yml Updates example caller to v7.0.1 SHA pin.
examples/fuzzing-pr-manual.yml Updates example caller to v7.0.1 SHA pin.
examples/fuzzing-multi-sanitizer.yml Updates example callers to v7.0.1 SHA pin.
examples/fuzzing-migration-example.md Updates migration doc examples to v7.0.1 SHA pin.
examples/fuzzing-custom-directory.yml Updates example caller to v7.0.1 SHA pin.
docs/workflows/workflow-optimizations.md Updates workflow examples to v7.0.1 SHA pin.
docs/workflows/README.md Updates general workflow usage and pinning guidance to SHA pins or point tags.
docs/workflows/python-supplemental-checks.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-standard-stack.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-sonarcloud.md Updates workflow usage examples to v7.0.1 SHA pin.
docs/workflows/python-snyk.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-snyk-iac.md Updates workflow usage examples to v7.0.1 SHA pin.
docs/workflows/python-slsa.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-security-analysis.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-scorecard.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-sbom.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-reuse.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-release.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-qlty-gate.md Updates workflow usage examples to v7.0.1 SHA pin.
docs/workflows/python-qlty-coverage.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-publish-pypi.md Updates workflow usage examples to v7.0.1 SHA pin.
docs/workflows/python-precommit.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-pr-validation.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-performance-regression.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-mutation.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-fuzzing.md Updates workflow usage examples to v7.0.1 SHA pin.
docs/workflows/python-fips-compatibility.md Updates workflow usage examples to v7.0.1 SHA pin.
docs/workflows/python-docs.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-docker.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-dependency-provenance.md Updates workflow usage examples to v7.0.1 SHA pin.
docs/workflows/python-container-security.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-compatibility.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-codecov.md Updates workflow usage example to v7.0.1 SHA pin.
docs/workflows/python-ci.md Updates workflow usage examples to v7.0.1 SHA pin.
docs/workflows/NEW_WORKFLOWS_SUMMARY.md Updates summary examples to v7.0.1 SHA pin.
docs/migration/pypi-publishing-migration.md Updates migration examples to v7.0.1 SHA pin.
docs/migration/image-detection-pypi-migration.md Updates migration example to v7.0.1 SHA pin.
CHANGELOG.md Corrects changelog intro and documents retirement of floating v1 under Unreleased.
.pre-commit-config.yaml Adds no-floating-v1 pre-commit hook configuration.
.github/workflows/supply-chain-promote-core.yml Updates commented usage examples to v7.0.1 SHA pin.
.github/workflows/supply-chain-mirror-verify.yml Updates commented usage examples to v7.0.1 SHA pin.
.github/workflows/supply-chain-consume-verify.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/supply-chain-build-verify.yml Updates commented usage examples to v7.0.1 SHA pin.
.github/workflows/snyk-weekly.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/security-analysis.yml Updates live reusable workflow pin to v7.0.1 SHA.
.github/workflows/scorecard.yml Updates live reusable workflow pin to v7.0.1 SHA.
.github/workflows/python-supplemental-checks.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-standard-stack.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-sonarcloud.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-snyk.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-snyk-iac.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-security-analysis.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-scorecard.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-sbom.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-reuse.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-release.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-qlty-gate.yml Updates commented usage examples to v7.0.1 SHA pin.
.github/workflows/python-qlty-coverage.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-publish-pypi.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-precommit.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-pr-validation.yml Updates commented usage examples to v7.0.1 SHA pin.
.github/workflows/python-performance-regression.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-mutation.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-fuzzing.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-fips-compatibility.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-docs.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-docker.yml Updates commented usage examples to v7.0.1 SHA pin.
.github/workflows/python-dependency-provenance.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-container-security.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-compatibility.yml Updates commented usage examples to v7.0.1 SHA pin.
.github/workflows/python-codecov.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/python-ci.yml Updates commented usage example to v7.0.1 SHA pin.
.github/workflows/dependency-provenance-weekly.yml Updates commented usage example to v7.0.1 SHA pin.

Comment thread scripts/check-no-floating-v1.sh Outdated
Comment on lines +23 to +29
if LC_ALL=C grep -Eql "${PATTERN}" "${file}" 2>/dev/null; then
found+=("${file}")
fi
if [[ "$(basename "${file}")" == "renovate.json" ]] \
&& grep -ql '"followTag"' "${file}" 2>/dev/null; then
found+=("${file} (followTag)")
fi
Comment thread USAGE_EXAMPLES.md Outdated

**Issue**: "Workflow not found"
**Fix**: Check path is exactly: `ByronWilliamsCPA/.github/.github/workflows/python-ci.yml@v1`
**Fix**: Check path is exactly: `ByronWilliamsCPA/.github/.github/workflows/python-ci.yml@d5cf99101d4150ae5832d154cb42993705a09e31 # v7.0.1`
williaby added a commit to ByronWilliamsCPA/fragrance-rater that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/MTG_AI that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/Unify that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/audio-processor that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/cookiecutter-python-template that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/family-office-portal that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/gleif that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/pp-security-master that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/python-libs that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/rag-processor that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to williaby/image-preprocessing-detector that referenced this pull request Jul 2, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to williaby/image-generation that referenced this pull request Jul 2, 2026
…tirement

The rule's description claimed org reusable workflows float a v1 tag;
that tag was frozen by the org tag-protection ruleset and has been
retired (ByronWilliamsCPA/.github#244). Behavior unchanged: this rule
only groups SHA-pin refresh PRs.
@williaby

williaby commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

PR Review

Premise: QUESTION (non-blocking). Sound, well-scoped v1-retirement that aligns the repo with its own CI-005 no-floating-tag policy. All external claims verified against live state: v1 tag dereferences to 6f71aec (frozen v1.1.0), v7.0.1 dereferences to d5cf991 (current main HEAD, the SHA pinned throughout), and the tag ruleset blocks update/deletion/non_fast_forward on refs/tags/v*. Sweep integrity byte-verified (173 mechanical pin pairs identical apart from the ref); workflow_call contract compatibility verified across the six-week pin jump for both live callers. No Critical findings.

Important

  1. Hook allowlist misses tests/update-pinned-actions.bats (check-no-floating-v1.sh#L21). That suite contains five legitimate @v1 fixture literals (lines 687, 690, 888-889, 896) that match the hook's own pattern; empirically confirmed (staging the file makes the hook exit 1). The next commit touching that file will be blocked. Fix: add tests/*.bats to the exclusion case statement, or move the literals into tests/fixtures/.
  2. git diff --cached failure makes the hook pass vacuously (check-no-floating-v1.sh#L14). The process-substitution exit status is invisible to set -e; any git failure converts to "no staged files, pass". Wrong polarity for a supply-chain guard (same latent flaw exists in check-no-em-dash.sh). Fix: write the diff output to a temp file, then mapfile from it.
  3. Case-sensitivity gap (check-no-floating-v1.sh#L12). GitHub resolves uses: owner/repo case-insensitively, so byronwilliamscpa/...@v1 evades the hook yet executes in Actions; until the follow-up tag deletion, such a ref silently runs stale v1.1.0 code. One-flag fix: grep -Eiql.
  4. Verification claims are vacuous or uncommitted. pre-commit run no-floating-v1 --all-files passes while scanning zero files (staged-scan design), so the green all-files run did not validate the regex, and CI never exercises this hook; "unit-tested against 9 cases" has no committed test. A Bats test would have caught items 1 and 2, and would keep the project CLAUDE.md script-coverage counts accurate (now ten scripts, six uncovered).
  5. Overlap with open Renovate PR chore(deps): Update GitHub Actions #240 on python-dependency-provenance.yml and supply-chain-promote-core.yml. This PR touches only comment regions there, so conflict risk is low; whichever merges second needs a rebase.

Worth folding in

  • renovate.json matchPackagePatterns is an unanchored regex (unaddressed Copilot comment from chore(deps): add Renovate rule for org workflow SHA pin updates #146) and deprecated since Renovate v41; this PR already rewrites that rule block, so switching to anchored matchPackageNames is nearly free.
  • PR body follow-up 1 is stale: standards-manifest CI-057 was already inverted (commit ac1df86 in the .claude repo, citing this PR). Residuals: devops-deployment-agent.md:81 still mandates followTag, plus fleet/cookiecutter propagation.
  • Guard scope: bare future majors (@v2+) and edge forms @v1. / @v1.2 escape the pattern; @v[0-9]+([^.0-9]|$) future-proofs it. The followTag check misses .renovate.json / renovate.json5 variants.

SonarQube: 0 issues, 0 hotspots (PR-specific). CodeRabbit: check is green but no review ran (rate-limited); do not read its check as coverage. Copilot: 2 comments, of which the staged-vs-worktree concern is neutralized by pre-commit's stash behavior in real runs; the USAGE_EXAMPLES.md:449 "path is exactly" wording nit is valid (the trailing # v7.0.1 is a YAML comment, not part of the path).

🤖 Generated with Claude Code

williaby and others added 3 commits July 2, 2026 12:06
The v1 tag froze at the v1.1.0 commit (6f71aec) when the org
tag-protection ruleset made all v* tags immutable, while main advanced
to v7.0.1. Docs still sold v1 as a moving tag, renovate.json followed
it (freezing SHA-pin updates), the starter templates and this repo's
own scorecard/security-analysis callers were SHA-pinned to the frozen
commit, and @v1 callers silently ran v1.1.0-era code, including the
Trivy scanner that PR #229 replaced after Trivy's release
infrastructure was compromised.

Commit fully to point-tag/SHA pinning (CI-005):

- renovate.json: drop followTag "v1" so Renovate advances org workflow
  SHA pins to the latest immutable release tag
- USAGE_EXAMPLES.md: rewrite Version Pinning around @<sha> # vX.Y.Z
  (recommended, Renovate-managed) and immutable @vX.Y.Z point tags
- CHANGELOG.md: correct the intro that claimed v1 is re-pointed as
  changes land; document the retirement under Unreleased
- sweep all @v1 usage examples (workflow headers, docs/workflows,
  examples, migration guides, READMEs) to the v7.0.1 SHA pin form
- bump workflow-templates/*.yml and this repo's scorecard.yml and
  security-analysis.yml off the frozen 6f71aec pin to v7.0.1
- add no-floating-v1 pre-commit guard (scripts/check-no-floating-v1.sh)
  blocking org-workflow @v1 references and followTag reintroduction

Intentionally untouched: tests/fixtures (negative fixtures),
tests/libs (vendored), docs/audits (historical record), and
third-party action examples (qlty-action, pr-size-labeler).

The stale v1 tag itself is deleted separately by an org admin; tag
deletion requires a ruleset bypass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…bats

Strengthen the guard added for the v1 tag retirement:

- widen the pattern from @v1 to any bare @vn major (a future @v7 would
  freeze callers the same way) and match the org name case-insensitively,
  since GitHub resolves uses: owners case-insensitively
- fail closed: route the staged-file listing through a temp file so a
  git failure cannot read as "no staged files", and treat grep exit >= 2
  (unreadable file) as a hook failure instead of a silent pass
- extend the followTag check to all Renovate config basenames
  (renovate.json5, .renovaterc variants), tolerate unquoted JSON5 keys,
  and line-anchor the key match so prose like "No followTag: ..." in a
  rule description does not trip the guard (caught by the guard itself
  blocking this very commit)
- anchor renovate.json matchPackageNames as regex patterns so the rule
  cannot match forks or lookalike repos
- clarify in USAGE_EXAMPLES that the # vX.Y.Z release comment is not
  part of the uses: path
- add tests/check-no-floating-v1.bats (16 cases: bare-major blocking,
  allowed pin forms, path exclusions, followTag key variants vs prose,
  fail-closed git behavior) and correct the CLAUDE.md script/coverage
  inventory, which had also drifted on sync-secrets.bats

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The line-anchored key match missed compact single-line JSON
({"followTag": "v1"}), where the key sits mid-line; bats cases 10-11
caught the false negative. Match on structural context instead: a real
key is preceded by an object opener, a separator, or line start
({, comma, or ^), while prose like "No followTag: ..." in a rule
description is preceded by a word and space, so both false positives
and false negatives are covered.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@williaby
williaby force-pushed the claude/retire-v1-floating-tag-0 branch from 4a05617 to 0ec5407 Compare July 2, 2026 19:07
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

@williaby

williaby commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

PR Fix Summary

Addressed the /pr-review findings in two commits on top of the rebase onto current main (d5cf991):

Hook hardening (44301df, 0ec5407) on scripts/check-no-floating-v1.sh:

  • Exclusion list now covers tests/*.bats (the update-pinned-actions suite embeds @v1 fixture literals that would have blocked its next edit; empirically confirmed)
  • Fail-closed: a git diff --cached failure or an unreadable staged file now fails the hook instead of passing vacuously (process-substitution exit was invisible to set -e)
  • Case-insensitive org match (GitHub resolves uses: owner/repo case-insensitively)
  • Pattern generalized to any bare @vN major; @vX.Y.Z point tags and SHA pins still pass
  • followTag guard covers renovate.json5 / .renovaterc* variants, unquoted JSON5 keys, and uses structural context ({, comma, or line start) so key detection catches compact single-line JSON while prose like "No followTag: ..." in the rule description does not false-positive

Tests (44301df): tests/check-no-floating-v1.bats, 16 cases, all green locally; runs in CI via shell-tests.yml. This replaces the previously uncommitted "9 cases" ad-hoc validation and corrects the CLAUDE.md script/coverage inventory.

Config (44301df): renovate.json org matcher migrated from deprecated, unanchored matchPackagePatterns to anchored matchPackageNames regexes (unaddressed Copilot finding from #146).

Docs (44301df): USAGE_EXAMPLES troubleshooting no longer presents the # vX.Y.Z release comment as part of the uses: path (Copilot's comment on line 449: fixed). On Copilot's other comment (staged-vs-worktree mismatch at check-no-floating-v1.sh:29): during a real commit, pre-commit stashes unstaged changes before hooks run, so the greped content equals the staged content; the gap exists only for direct invocation outside pre-commit, and the fail-closed hardening narrows that residual further. Declined as designed, with the read path hardened.

PR body updated: verification section now describes the committed Bats coverage and the hook's staged-scope semantics; follow-up 1 notes the standards-manifest CI-057 inversion already landed (.claude commit ac1df86).

Declined with rationale: CHANGELOG ### Fixed placement (matches the file's existing precedent under [Unreleased]); no action on the open Renovate PR #240 overlap (comment-region only; whichever merges second rebases trivially).

🤖 Generated with Claude Code

@williaby
williaby added this pull request to the merge queue Jul 2, 2026
Merged via the queue into main with commit 9094060 Jul 2, 2026
42 of 43 checks passed
@williaby
williaby deleted the claude/retire-v1-floating-tag-0 branch July 2, 2026 19:21
williaby added a commit to ByronWilliamsCPA/pp-security-master that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/MTG_AI that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/Unify that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/audio-processor that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/cookiecutter-python-template that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/family-office-portal that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/fragrance-rater that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/gleif that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/pp-security-master that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/python-libs that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to ByronWilliamsCPA/rag-processor that referenced this pull request Sep 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to williaby/image-generation that referenced this pull request Sep 4, 2026
…tirement

The rule's description claimed org reusable workflows float a v1 tag;
that tag was frozen by the org tag-protection ruleset and has been
retired (ByronWilliamsCPA/.github#244). Behavior unchanged: this rule
only groups SHA-pin refresh PRs.
williaby added a commit to williaby/image-preprocessing-detector that referenced this pull request Sep 4, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to williaby/image-preprocessing-detector that referenced this pull request Oct 3, 2026
* fix(renovate): drop followTag on retired v1 floating tag

The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).

* fix(review): migrate deprecated matchPackagePatterns to matchPackageNames

Address CodeRabbit finding on PR #205: the org-workflow Renovate rule used
the deprecated matchPackagePatterns matcher. matchPackageNames matches the
two literal package names exactly (no regex dot ambiguity) and is
consistent with the other rules in renovate.json. Validated with
renovate-config-validator.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
williaby added a commit to ByronWilliamsCPA/Unify that referenced this pull request Oct 3, 2026
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
williaby added a commit to williaby/image-generation that referenced this pull request Oct 31, 2026
…tirement (#75)

* docs(renovate): correct org-workflow rule description after v1 tag retirement

The rule's description claimed org reusable workflows float a v1 tag;
that tag was frozen by the org tag-protection ruleset and has been
retired (ByronWilliamsCPA/.github#244). Behavior unchanged: this rule
only groups SHA-pin refresh PRs.

* docs(renovate): restore original formatting, description change only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants